Addressing comments from Juan

redhat-best-practices-for-k8s · Dec 14, 2023 · 2111aca · 2111aca
1 parent 997c019
commit 2111aca
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/pkg/checksdb/check.go b/pkg/checksdb/check.go
@@ -45,8 +45,8 @@ type Check struct {
 
 	Result         CheckResult
 	CapturedOutput string
-	Details        string
-	SkipReason     string
+	details        string
+	skipReason     string
 
 	logger     *log.Logger
 	logArchive *strings.Builder
@@ -190,7 +190,7 @@ func (check *Check) SetResult(compliantObjects, nonCompliantObjects []*testhelpe
 		check.LogError("Failed to get result objects string for check %s: %v", check.ID, err)
 	}
 
-	check.Details = resultObjectsStr
+	check.details = resultObjectsStr
 
 	// If an error/panic happened before, do not change the result.
 	if check.Result == CheckResultError {
@@ -199,11 +199,11 @@ func (check *Check) SetResult(compliantObjects, nonCompliantObjects []*testhelpe
 
 	if len(nonCompliantObjects) > 0 {
 		check.Result = CheckResultFailed
-		check.SkipReason = resultObjectsStr
+		check.skipReason = ""
 	} else if len(compliantObjects) == 0 {
 		// Mark this check as skipped.
 		check.LogWarn("Check %s marked as skipped as both compliant and non-compliant objects lists are empty.", check.ID)
-		check.SkipReason = "Compliant and non-compliant objects lists are empty."
+		check.skipReason = "Compliant and non-compliant objects lists are empty."
 		check.Result = CheckResultSkipped
 	}
 }
@@ -217,7 +217,7 @@ func (check *Check) SetResultFailed(reason string) {
 	}
 
 	check.Result = CheckResultFailed
-	check.SkipReason = reason
+	check.skipReason = reason
 }
 
 func (check *Check) SetResultSkipped(reason string) {
@@ -229,7 +229,7 @@ func (check *Check) SetResultSkipped(reason string) {
 	}
 
 	check.Result = CheckResultSkipped
-	check.SkipReason = reason
+	check.skipReason = reason
 }
 
 func (check *Check) SetResultError(reason string) {
@@ -245,15 +245,15 @@ func (check *Check) SetResultError(reason string) {
 		return
 	}
 	check.Result = CheckResultError
-	check.SkipReason = reason
+	check.skipReason = reason
 }
 
 func (check *Check) SetResultAborted(reason string) {
 	check.mutex.Lock()
 	defer check.mutex.Unlock()
 
 	check.Result = CheckResultAborted
-	check.SkipReason = reason
+	check.skipReason = reason
 }
 
 func (check *Check) Run() error {

diff --git a/pkg/checksdb/checksdb.go b/pkg/checksdb/checksdb.go
@@ -123,9 +123,9 @@ func recordCheckResult(check *Check) {
 		StartTime:          check.StartTime.String(),
 		EndTime:            check.EndTime.String(),
 		Duration:           int(check.EndTime.Sub(check.StartTime).Seconds()),
-		SkipReason:         check.SkipReason,
+		SkipReason:         check.skipReason,
 		CapturedTestOutput: check.GetLogs(),
-		CheckDetails:       check.Details,
+		CheckDetails:       check.details,
 
 		CategoryClassification: &claim.CategoryClassification{
 			Extended: identifiers.Catalog[claimID].CategoryClassification[identifiers.Extended],