Fix for fatal error in diagnostics (#1715)

redhat-best-practices-for-k8s · Dec 15, 2023 · 720a565 · 720a565
1 parent a86a981
commit 720a565
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/pkg/diagnostics/diagnostics.go b/pkg/diagnostics/diagnostics.go
@@ -85,14 +85,16 @@ func GetHwInfoAllNodes() (out map[string]NodeHwInfo) {
 		hw := NodeHwInfo{}
 		lscpu, err := getHWJsonOutput(debugPod, o, lscpuCommand)
 		if err != nil {
-			logrus.Errorf("problem getting lscpu for node %s", debugPod.Spec.NodeName)
+			logrus.Error("problem getting lscpu for node %s", debugPod.Spec.NodeName)
+		} else {
+			var ok bool
+			temp, ok := lscpu.(map[string]interface{})
+			if !ok {
+				logrus.Error("problem casting lscpu field for node %s, lscpu=%v", debugPod.Spec.NodeName, lscpu)
+			} else {
+				hw.Lscpu = temp["lscpu"]
+			}
 		}
-		var ok bool
-		hw.Lscpu, ok = lscpu.(map[string]interface{})["lscpu"]
-		if !ok {
-			logrus.Errorf("problem casting lscpu field for node %s, lscpu=%v", debugPod.Spec.NodeName, lscpu)
-		}
-
 		hw.IPconfig, err = getHWJsonOutput(debugPod, o, ipCommand)
 		if err != nil {
 			logrus.Errorf("problem getting ip config for node %s", debugPod.Spec.NodeName)