Add logging; unit tests for UBI9 (#2191)

* Add logging; unit tests for UBI9 * Address comments
redhat-best-practices-for-k8s · Jun 25, 2024 · cb5fe52 · cb5fe52
1 parent 14f49ca
commit cb5fe52
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/cnf-certification-test/platform/isredhat/isredhat.go b/cnf-certification-test/platform/isredhat/isredhat.go
@@ -45,6 +45,7 @@ func NewBaseImageTester(client clientsholder.Command, ctx clientsholder.Context)
 
 func (b *BaseImageInfo) TestContainerIsRedHatRelease() (bool, error) {
 	output, err := b.runCommand(`if [ -e /etc/redhat-release ]; then cat /etc/redhat-release; else echo \"Unknown Base Image\"; fi`)
+	log.Info("Output from /etc/redhat-release: %q", output)
 	if err != nil {
 		return false, err
 	}

diff --git a/cnf-certification-test/platform/isredhat/isredhat_test.go b/cnf-certification-test/platform/isredhat/isredhat_test.go
@@ -82,6 +82,13 @@ func TestTestContainerIsRedHatRelease(t *testing.T) {
 			expectedResult: false,
 			expectedErr:    errors.New("random error"),
 		},
+		{ // Test Case #4 - Add UBI9 output
+			resultStdOut:   "Red Hat Enterprise Linux release 9.4 (Plow)",
+			resultStdErr:   "",
+			resultErr:      nil,
+			expectedResult: true,
+			expectedErr:    nil,
+		},
 	}
 
 	for _, tc := range testCases {