Allow CNF Cert Suite app's go-clients to work in a k8s pod. #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will allow the go-clients to be initialized properly in case the app is running inside a pod in a k8s/OCP cluster. The method rest.InClusterConfig() reads the pod's SA tokens/creentials and returns a rest.Config struct that can be used to initialize all the go-clients. If that method returns an error, it assumes it's running outside a cluster, using the provided filenames to create the rest.Config.
edcdavid
approved these changes
Oct 19, 2023
The preflight's Operator checks were failing because the clientcmdapi.Config struct wasn't filled up properly.
sebrandon1
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow the go-clients to be initialized properly in case the app is running inside a pod in a k8s/OCP cluster.
The method rest.InClusterConfig() reads the pod's SA tokens/creentials and returns a rest.Config struct that can be used to initialize all the go-clients.
If that method returns an error, it assumes it's running outside a cluster, using the provided filenames to create the rest.Config.