Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website for our cnf #1544

Merged
merged 39 commits into from
Nov 9, 2023
Merged

website for our cnf #1544

merged 39 commits into from
Nov 9, 2023

Conversation

aabughosh
Copy link
Contributor

to run need to call ./run-cnf-suites.sh -l lifecycle -s true -s new filed mean if i want to run that from the website

to run need to call  ./run-cnf-suites.sh -l lifecycle -s true
-s new filed mean if i want to run that from the website
Copy link
Member

@edcdavid edcdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some initial comments, will add more later

cnf-certification-test/suite_test.go Outdated Show resolved Hide resolved
cnf-certification-test/suite_test.go Outdated Show resolved Hide resolved
cnf-certification-test/suite_test.go Outdated Show resolved Hide resolved
cnf-certification-test/suite_test.go Outdated Show resolved Hide resolved
cnf-certification-test/suite_test.go Outdated Show resolved Hide resolved
cnf-certification-test/suite_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jmontesi jmontesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, try to avoid code duplication between the CLI and Server modes, move all the server code to a different file and rename the amalpro folder.

cnf-certification-test/log.log Outdated Show resolved Hide resolved
cnf-certification-test/suite_test.go Outdated Show resolved Hide resolved
cnf-certification-test/suite_test.go Outdated Show resolved Hide resolved
cnf-certification-test/suite_test.go Outdated Show resolved Hide resolved
cnf-certification-test/suite_test.go Outdated Show resolved Hide resolved
cnf-certification-test/suite_test.go Outdated Show resolved Hide resolved
cnf-certification-test/suite_test.go Outdated Show resolved Hide resolved
@ramperher
Copy link
Collaborator

The DCI job is not passing because tnf is not being even executed, see error above from the execution.log file:

time="2023-10-23T10:00:11Z" level=info msg="Saving environment variables & parameters."
time="2023-10-23T10:00:11Z" level=info msg="Environment: {Home:/root Kubeconfig:/usr/tnf/kubeconfig/config ConfigurationPath:/usr/tnf/config/tnf_config.yml NonIntrusiveOnly:false LogLevel:debug OfflineDB:/usr/offline-db AllowPreflightInsecure:true PfltDockerconfig:/usr/tnf/dockercfg/config.json IncludeWebFilesInOutputFolder:false OmitArtifactsZipFile:false EnableDataCollection:false}"
�[36mINFO   �[0m[Oct 23 10:00:11.603][suite_test.go: 124] Log level set to: debug                      
�[36mINFO   �[0m[Oct 23 10:00:11.604][suite_test.go: 225] TNF Version         : Unreleased build post v4.5.1 ( 7cff6d74e3d75b3b1e21770c4431dcd55a11033d ) 
�[36mINFO   �[0m[Oct 23 10:00:11.604][suite_test.go: 226] Claim Format Version: v0.1.0                 
�[36mINFO   �[0m[Oct 23 10:00:11.604][suite_test.go: 227] Ginkgo Version      : 2.13.0                 
�[36mINFO   �[0m[Oct 23 10:00:11.604][suite_test.go: 228] Labels filter       : common,telco,extended,preflight 
�[36mINFO   �[0m[Oct 23 10:00:11.604][suite_test.go: 229] *serveRun       : true                       
�[36mINFO   �[0m[Oct 23 10:00:11.604][suite_test.go: 230] starting the server                          
�[36mINFO   �[0m[Oct 23 10:00:11.604][suite_test.go: 156] inside starting the server                   
Server is running on :8080...
panic: listen tcp :8080: bind: address already in use

goroutine 165 [running]:
github.com/test-network-function/cnf-certification-test/cnf-certification-test.startServer()
	/usr/tnf/tnf-src/cnf-certification-test/suite_test.go:204 +0x1bb
created by github.com/test-network-function/cnf-certification-test/cnf-certification-test.TestTest in goroutine 164
	/usr/tnf/tnf-src/cnf-certification-test/suite_test.go:232 +0x3b1
+ RESULT=2
+ set +o pipefail
+ exit 2

@sebrandon1 sebrandon1 merged commit 3ed0838 into main Nov 9, 2023
9 checks passed
@sebrandon1 sebrandon1 deleted the cnfweb branch November 9, 2023 17:34
@bennypowers
Copy link

Congratulations on the merge @aabughosh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants