performance: avoid failing test case if a process cannot be found #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It applies to rt-apps-no-exec-probes. The reason a process cannot be found after it has been properly retrieved previously could be that the process has finished. So, in this case it seems more adequate to just ignore it than to produce an error. If the error is of another kind the container is added to the non compliant list but the processing for that container continues instead of breaking, to have more info on the processes. The commit also changes the verification order in that test case, making the faster check of exec probes at the beginning, skipping the slower part in which the processes are list. Finally, the compliant containers are added to its list with the reason for compliance.
greyerof
approved these changes
Oct 27, 2023
edcdavid
reviewed
Oct 27, 2023
edcdavid
reviewed
Oct 27, 2023
edcdavid
reviewed
Oct 30, 2023
sebrandon1
approved these changes
Oct 30, 2023
edcdavid
reviewed
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It applies to
rt-apps-no-exec-probes.The reason a process cannot be found after it has been properly retrieved previously could be that the process has finished. So, in this case it seems more adequate to just ignore it than to produce an error. If the error is of another kind, the container is added to the non compliant list but the processing for that container continues instead of breaking, to have more info on the processes.
The commit also changes the verification order in that test case, making the faster check of exec probes at the beginning, skipping the slower part in which the processes are list.
Finally, the compliant containers are added to its list with the reason for compliance.