claim file: move data structs and handlers to the CNF repo #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebrandon1
reviewed
Nov 13, 2023
| @@ -1 +1,230 @@ | |||
| This is a placeholder for the results.html file that will be downloaded from https://github.com/test-network-function/parser when this project is built | |||
There was a problem hiding this comment.
Looks like this got accidentally built.
|
Closed in favor of PR#1613. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The claim file used for presenting the results of the CNF Certification Suite as well as some other information related to the CNF under test, the test environment or the configuration is an asset that belongs to the CNF Certification Suite and that no other tool is generating, that's why it might be more appropriate that the data structs and functions to handle it are placed in the CNF Certification Suite repository.
In this PR, the whole
pkg/claimpackage has been moved fromtest-network-function-claimto this repo'spkgdirectory. As a result, theclaimFormatfield of the claim file has been deleted, as now the claim file version will be the same as the CNF Certification Suite version.This PR makes the QE repo ready to work with the claim package in its new location.