Transition performance suite to ginkgoless. #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, added a couple of generic helper functions that create skip functions to be used in the check.WithSkipCheckFn() call. - testhelper.GetNoContainersUnderTestSkipFn(env) - testhelper.GetNoPodsUnderTestSkipFn(env) Both return a closure function over the env pointer, and the signature of that function is the expected by the checksdb's runner: func() (skip bool, string)
sebrandon1
approved these changes
Nov 14, 2023
greyerof
added a commit
to greyerof/certsuite
that referenced
this pull request
Nov 15, 2023
Non-backward compatibility: the tc/check "affiliated-certification-helm-version" will be skipped if no helm chart releases were discovered. Also, in case we discovered some chart releases and helm is v3, every chart release will be added as a compliant report object. PR redhat-best-practices-for-k8s#1620 needs to be merged first, as this code uses the helper function "testhelper.GetNoContainersUnderTestSkipFn()" created by that PR. Also, added the expansion of the "args..." in the ClaimFilePrintf call to Logf.
jmontesi
approved these changes
Nov 16, 2023
greyerof
merged commit aa43774
into
redhat-best-practices-for-k8s:ginkgo_removal
8 checks passed
sebrandon1
pushed a commit
to sebrandon1/certsuite
that referenced
this pull request
Nov 17, 2023
…r-k8s#1620) Also, added a couple of generic helper functions that create skip functions to be used in the check.WithSkipCheckFn() call. - testhelper.GetNoContainersUnderTestSkipFn(env) - testhelper.GetNoPodsUnderTestSkipFn(env) Both return a closure function over the env pointer, and the signature of that function is the expected by the checksdb's runner: func() (skip bool, string)
sebrandon1
pushed a commit
to sebrandon1/certsuite
that referenced
this pull request
Nov 17, 2023
…r-k8s#1620) Also, added a couple of generic helper functions that create skip functions to be used in the check.WithSkipCheckFn() call. - testhelper.GetNoContainersUnderTestSkipFn(env) - testhelper.GetNoPodsUnderTestSkipFn(env) Both return a closure function over the env pointer, and the signature of that function is the expected by the checksdb's runner: func() (skip bool, string)
sebrandon1
pushed a commit
to sebrandon1/certsuite
that referenced
this pull request
Nov 21, 2023
…r-k8s#1620) Also, added a couple of generic helper functions that create skip functions to be used in the check.WithSkipCheckFn() call. - testhelper.GetNoContainersUnderTestSkipFn(env) - testhelper.GetNoPodsUnderTestSkipFn(env) Both return a closure function over the env pointer, and the signature of that function is the expected by the checksdb's runner: func() (skip bool, string)
sebrandon1
pushed a commit
to sebrandon1/certsuite
that referenced
this pull request
Nov 21, 2023
…r-k8s#1620) Also, added a couple of generic helper functions that create skip functions to be used in the check.WithSkipCheckFn() call. - testhelper.GetNoContainersUnderTestSkipFn(env) - testhelper.GetNoPodsUnderTestSkipFn(env) Both return a closure function over the env pointer, and the signature of that function is the expected by the checksdb's runner: func() (skip bool, string)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, added a couple of generic helper functions that create skip functions to be used in the check.WithSkipCheckFn() call.
Both return a closure function over the env pointer, and the signature of that function is the expected by the checksdb's runner:
func() (skip bool, string)