Fix for the webserver kubeconfig file handling. #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kubeconfig sent via web form is now copied to a temporary file. Also, I created a new function in the clientsholder package to recreate the oc clients for each webserver run, using the kubceonfig file sent via web form.
sebrandon1
approved these changes
Nov 15, 2023
aabughosh
approved these changes
Nov 15, 2023
greyerof
merged commit f1aa8da
into
redhat-best-practices-for-k8s:ginkgo_removal
8 checks passed
sebrandon1
pushed a commit
to sebrandon1/certsuite
that referenced
this pull request
Nov 17, 2023
…s-for-k8s#1625) The kubeconfig sent via web form is now copied to a temporary file. Also, I created a new function in the clientsholder package to recreate the oc clients for each webserver run, using the kubceonfig file sent via web form.
sebrandon1
pushed a commit
to sebrandon1/certsuite
that referenced
this pull request
Nov 17, 2023
…s-for-k8s#1625) The kubeconfig sent via web form is now copied to a temporary file. Also, I created a new function in the clientsholder package to recreate the oc clients for each webserver run, using the kubceonfig file sent via web form.
sebrandon1
pushed a commit
to sebrandon1/certsuite
that referenced
this pull request
Nov 21, 2023
…s-for-k8s#1625) The kubeconfig sent via web form is now copied to a temporary file. Also, I created a new function in the clientsholder package to recreate the oc clients for each webserver run, using the kubceonfig file sent via web form.
sebrandon1
pushed a commit
to sebrandon1/certsuite
that referenced
this pull request
Nov 21, 2023
…s-for-k8s#1625) The kubeconfig sent via web form is now copied to a temporary file. Also, I created a new function in the clientsholder package to recreate the oc clients for each webserver run, using the kubceonfig file sent via web form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kubeconfig sent via web form is now copied to a temporary file.
Also, I created a new function in the clientsholder package to recreate the oc clients for each webserver run, using the kubceonfig file sent via web form.