Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition lifecycle suite to ginkgoless #1627

Conversation

sebrandon1
Copy link
Member

@sebrandon1 sebrandon1 commented Nov 15, 2023

Similar to: #1616

The biggest changes here that are out of the ordinary are to the pod-recreation test which was still using direct ginkgo.Fail calls.

@sebrandon1
Copy link
Member Author

Marked WIP until I finish up the ginkgo removal from the suite.go.

@sebrandon1 sebrandon1 force-pushed the lifecycle_ginkgoless branch 5 times, most recently from 2a73282 to 3b3239c Compare November 21, 2023 15:19
@sebrandon1 sebrandon1 merged commit 765cee0 into redhat-best-practices-for-k8s:ginkgo_removal Nov 21, 2023
7 checks passed
@sebrandon1 sebrandon1 deleted the lifecycle_ginkgoless branch November 21, 2023 16:03
sebrandon1 added a commit to sebrandon1/certsuite that referenced this pull request Nov 21, 2023
…8s#1627)

* Transition lifecycle suite to ginkgoless

* Use testhelper funcs
sebrandon1 added a commit to sebrandon1/certsuite that referenced this pull request Nov 21, 2023
…8s#1627)

* Transition lifecycle suite to ginkgoless

* Use testhelper funcs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant