Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webserver: add implementation for uploading tnf config file and add all the fields #1644

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

aabughosh
Copy link
Contributor

No description provided.

@aabughosh aabughosh changed the title test test add implementation for uploading tnf config file and add all the fleds Nov 19, 2023
@aabughosh aabughosh changed the title add implementation for uploading tnf config file and add all the fleds add implementation for uploading tnf config file and add all the fildes Nov 19, 2023
@jmontesi jmontesi changed the title add implementation for uploading tnf config file and add all the fildes webserver: add implementation for uploading tnf config file and add all the fields Nov 20, 2023
Copy link
Member

@sebrandon1 sebrandon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments about versions.

@@ -9,6 +10,9 @@
sizes="any"
href="https://ux.redhat.com/assets/logo-red-hat.svg">
<link rel="stylesheet" href="https://ux.redhat.com/assets/packages/@rhds/elements/elements/rh-footer/rh-footer-lightdom.css">
<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JQuery v3.7.1 is the latest release. Should we be using that?

@@ -9,6 +10,9 @@
sizes="any"
href="https://ux.redhat.com/assets/logo-red-hat.svg">
<link rel="stylesheet" href="https://ux.redhat.com/assets/packages/@rhds/elements/elements/rh-footer/rh-footer-lightdom.css">
<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.0.13/css/all.css" integrity="sha384-DNOHZ68U8hZfKXOrtjWvjxusGo9WQnrNx2sqG0tfsghAvtVlRW3tvkXWZh58N9jp" crossorigin="anonymous">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Font-Awesome's latest release is v6.4.2.

Copy link
Member

@sebrandon1 sebrandon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can approve/merge this and address the updates in a secondary PR if needed.

@sebrandon1 sebrandon1 merged commit ac883e6 into ginkgo_removal Nov 20, 2023
7 checks passed
@sebrandon1 sebrandon1 deleted the test2 branch November 20, 2023 21:16
sebrandon1 pushed a commit to sebrandon1/certsuite that referenced this pull request Nov 21, 2023
…ll the fields (redhat-best-practices-for-k8s#1644)

* test test

* Update webserver.go

* Update index.js

* Update webserver.go
sebrandon1 pushed a commit to sebrandon1/certsuite that referenced this pull request Nov 21, 2023
…ll the fields (redhat-best-practices-for-k8s#1644)

* test test

* Update webserver.go

* Update index.js

* Update webserver.go
sebrandon1 pushed a commit to sebrandon1/certsuite that referenced this pull request Nov 21, 2023
…ll the fields (redhat-best-practices-for-k8s#1644)

* test test

* Update webserver.go

* Update index.js

* Update webserver.go
sebrandon1 pushed a commit to sebrandon1/certsuite that referenced this pull request Nov 21, 2023
…ll the fields (redhat-best-practices-for-k8s#1644)

* test test

* Update webserver.go

* Update index.js

* Update webserver.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants