-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webserver: add implementation for uploading tnf config file and add all the fields #1644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments about versions.
@@ -9,6 +10,9 @@ | |||
sizes="any" | |||
href="https://ux.redhat.com/assets/logo-red-hat.svg"> | |||
<link rel="stylesheet" href="https://ux.redhat.com/assets/packages/@rhds/elements/elements/rh-footer/rh-footer-lightdom.css"> | |||
<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JQuery v3.7.1 is the latest release. Should we be using that?
@@ -9,6 +10,9 @@ | |||
sizes="any" | |||
href="https://ux.redhat.com/assets/logo-red-hat.svg"> | |||
<link rel="stylesheet" href="https://ux.redhat.com/assets/packages/@rhds/elements/elements/rh-footer/rh-footer-lightdom.css"> | |||
<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script> | |||
<link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.0.13/css/all.css" integrity="sha384-DNOHZ68U8hZfKXOrtjWvjxusGo9WQnrNx2sqG0tfsghAvtVlRW3tvkXWZh58N9jp" crossorigin="anonymous"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Font-Awesome's latest release is v6.4.2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can approve/merge this and address the updates in a secondary PR if needed.
…ll the fields (redhat-best-practices-for-k8s#1644) * test test * Update webserver.go * Update index.js * Update webserver.go
…ll the fields (redhat-best-practices-for-k8s#1644) * test test * Update webserver.go * Update index.js * Update webserver.go
…ll the fields (redhat-best-practices-for-k8s#1644) * test test * Update webserver.go * Update index.js * Update webserver.go
…ll the fields (redhat-best-practices-for-k8s#1644) * test test * Update webserver.go * Update index.js * Update webserver.go
No description provided.