Switch to 1-to-1 TestID to Result struct #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebrandon1
force-pushed
the
remove_slice
branch
from
f2cc73a to
7940d32
Compare
|
Marked WIP until I get the gradetool passing. |
sebrandon1
force-pushed
the
remove_slice
branch
2 times, most recently
from
eaf3818 to
fad5c3c
Compare
sebrandon1
commented
Nov 28, 2023
edcdavid
reviewed
Nov 28, 2023
edcdavid
reviewed
Nov 28, 2023
sebrandon1
force-pushed
the
remove_slice
branch
3 times, most recently
from
2abad9c to
384cfaa
Compare
Adjust claimFormat
sebrandon1
force-pushed
the
remove_slice
branch
from
384cfaa to
649039d
Compare
edcdavid
approved these changes
Nov 29, 2023
greyerof
approved these changes
Nov 30, 2023
sebrandon1
merged commit 8c81c42
into
redhat-best-practices-for-k8s:ginkgo_removal
7 checks passed
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the
[]claim.Resulttoclaim.Resultwhen it comes to results being recorded in the claim file.This involved changing all of the
testdata/folders that contained sample JSON files.