Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename poststart test #1698

Conversation

edcdavid
Copy link
Member

@edcdavid edcdavid commented Dec 5, 2023

No description provided.

@sebrandon1
Copy link
Member

This will need a corresponding PR in QE to change the reference. There is a ginkgo_removal branch there as well.

@jmontesi
Copy link
Contributor

jmontesi commented Dec 7, 2023

Maybe the test lifecycle-container-shutdown should also be renamed to lifecycle-container-prestop, so that both tests names use the specific container option.

@edcdavid edcdavid force-pushed the rename-poststart-test branch from c3dc0c9 to a3fdc9c Compare December 7, 2023 19:38
@edcdavid edcdavid merged commit 117a250 into redhat-best-practices-for-k8s:ginkgo_removal Dec 11, 2023
7 checks passed
edcdavid added a commit to edcdavid/cnf-certification-test that referenced this pull request Dec 12, 2023
edcdavid added a commit to edcdavid/cnf-certification-test that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants