log: remove loghelper package #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functions in the loghelper package are not necessary anymore with the new log package as the check multilogger is able to log into the log file as well as into each check's log archive, which can be later used to fill the log section in the claim file. Helper functions for the checks receive now the logger instance of the check, so that logs can be written inside those functions but tagged with the check's name and recorded in that check's log archive. For this, a new Logger type has been defined, as well as a set of methods to be used by the logger instance. With the help of the new Logger type a small refactor of the log package is included in this change. Now the "log/slog" library is only used inside this package, isolating the rest of the code from any other logging libray than our internal log package.
sebrandon1
approved these changes
Dec 13, 2023
greyerof
approved these changes
Dec 13, 2023
jmontesi
merged commit c8ed3ad
into
redhat-best-practices-for-k8s:ginkgo_removal
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions in the loghelper package are not necessary anymore with the new log package as the check multilogger is able to log into the log file as well as into each check's log archive, which can be later used to fill the log section in the claim file.
Helper functions for the checks receive now the logger instance of the check, so that logs can be written inside those functions but tagged with the check's name and recorded in that check's log archive. For this, a new Logger type has been defined, as well as a set of methods to be used by the logger instance.
With the help of the new Logger type a small refactor of the log package is included in this change. Now the "log/slog" library is only used inside this package, isolating the rest of the code from any other logging libray than our internal log package.