Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge branch 'main' into ginkgo_removal #1752

Merged
merged 63 commits into from
Dec 19, 2023
Merged

Merge branch 'main' into ginkgo_removal #1752

merged 63 commits into from
Dec 19, 2023

Conversation

greyerof
Copy link
Contributor

No description provided.

dependabot bot and others added 30 commits November 13, 2023 11:47
@dependabot
Bump github.com/onsi/ginkgo/v2 from 2.13.0 to 2.13.1 (redhat-best-pra…
a592221 
…ctices-for-k8s#1610)

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.13.0 to 2.13.1.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.13.0...v2.13.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/test-network-function/privileged-daemonset (redhat-be…
11a816b 
…st-practices-for-k8s#1612)

Bumps [github.com/test-network-function/privileged-daemonset](https://github.com/test-network-function/privileged-daemonset) from 1.0.14 to 1.0.15.
- [Release notes](https://github.com/test-network-function/privileged-daemonset/releases)
- [Commits](redhat-best-practices-for-k8s/privileged-daemonset@v1.0.14...v1.0.15)

---
updated-dependencies:
- dependency-name: github.com/test-network-function/privileged-daemonset
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@sebrandon1
Temporarily disable QE parallel flag for nightlies (redhat-best-pract…
ba41000 
…ices-for-k8s#1617)
@dependabot @rdavid
Bump github.com/test-network-function/test-network-function-claim (re…
a88f794 
…dhat-best-practices-for-k8s#1611)

Bumps [github.com/test-network-function/test-network-function-claim](https://github.com/test-network-function/test-network-function-claim) from 1.0.30 to 1.0.31.
- [Release notes](https://github.com/test-network-function/test-network-function-claim/releases)
- [Commits](redhat-best-practices-for-k8s/certsuite-claim@v1.0.30...v1.0.31)

---
updated-dependencies:
- dependency-name: github.com/test-network-function/test-network-function-claim
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: David Rabkin <[email protected]>
@github-actions @sebrandon1
Update RHCOS to OCP version map (redhat-best-practices-for-k8s#1618)
93434f7 
Co-authored-by: sebrandon1 <[email protected]>
@sebrandon1
Disable Go cache for self-hosted (redhat-best-practices-for-k8s#1626)
a8640e4
@sebrandon1
Add retries to QE nightlies (redhat-best-practices-for-k8s#1628)
2e00877
@greyerof
Fix gchat alert message. (redhat-best-practices-for-k8s#1630)
3d88e84 
After testing it in a private repo, it works when the webhook URL+query
is surrounded by single quotes.
@github-actions @sebrandon1
Update RHCOS to OCP version map (redhat-best-practices-for-k8s#1629)
f507a55 
Co-authored-by: sebrandon1 <[email protected]>
@greyerof
Fixed function AreCPUResourcesWholeUnits(). (redhat-best-practices-fo…
61ab658 
…r-k8s#1631)

The bug happens when deploying pods with containers that don't have any
cpu req/limit defined in its spec but they do have any other resource
(like mem) set.

cut.Resources.Requests and cut.Resources.Limits are maps, whose keys are
the different resources (mem, cpu, hugepages) that were explicitly set
in the container spec.

Requests.Cpu() returns a defaulted (zeroed) Quantity for the cpu
resource if that resource type doesn't exist in the requests map, which
will happen if cpu reqs/limits are not explicitly set in the pod spec.
@dependabot
Bump ubi8/ubi from 8.8-1067.1698056881 to 8.9-1028 (redhat-best-pract…
7dc8f40 
…ices-for-k8s#1633)

Bumps ubi8/ubi from 8.8-1067.1698056881 to 8.9-1028.

---
updated-dependencies:
- dependency-name: ubi8/ubi
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jmontesi
Bump github.com/test-network-function/oct from 0.0.3 to 0.0.4 (redhat…
8507205 
…-best-practices-for-k8s#1632)
@dependabot
Bump ubi8/ubi-minimal from 8.8-1072.1697626218 to 8.9-1029 (redhat-be…
fcdd895 
…st-practices-for-k8s#1634)

Bumps ubi8/ubi-minimal from 8.8-1072.1697626218 to 8.9-1029.

---
updated-dependencies:
- dependency-name: ubi8/ubi-minimal
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump k8s.io/kubectl from 0.28.3 to 0.28.4 (redhat-best-practices-for-…
3563734 
…k8s#1636)

Bumps [k8s.io/kubectl](https://github.com/kubernetes/kubectl) from 0.28.3 to 0.28.4.
- [Commits](kubernetes/kubectl@v0.28.3...v0.28.4)

---
updated-dependencies:
- dependency-name: k8s.io/kubectl
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@github-actions @sebrandon1
Update RHCOS to OCP version map (redhat-best-practices-for-k8s#1641)
5b34225 
Co-authored-by: sebrandon1 <[email protected]>
@sebrandon1
Re-enable QE PR checks (redhat-best-practices-for-k8s#1640)
213b1b4
@shirmoran
enable collector's sanity check (redhat-best-practices-for-k8s#1606)
1ee5694 
* enable collector's sanity check

* added tmate session for testing

* disable tmate session
@edcdavid
Fix catalog links (redhat-best-practices-for-k8s#1650)
8ed6607
@sebrandon1
Prepare for v4.5.6 (redhat-best-practices-for-k8s#1651)
3a209a4
@sebrandon1
Temp. disable collector sanity check (redhat-best-practices-for-k8s#1653
eebaeb6 
)
@dependabot
Bump github.com/mittwald/go-helm-client from 0.12.3 to 0.12.4 (redhat…
b364be7 
…-best-practices-for-k8s#1652)

Bumps [github.com/mittwald/go-helm-client](https://github.com/mittwald/go-helm-client) from 0.12.3 to 0.12.4.
- [Release notes](https://github.com/mittwald/go-helm-client/releases)
- [Commits](mittwald/go-helm-client@v0.12.3...v0.12.4)

---
updated-dependencies:
- dependency-name: github.com/mittwald/go-helm-client
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/deckarep/golang-set/v2 from 2.3.1 to 2.4.0 (redhat-be…
2663a34 
…st-practices-for-k8s#1656)

Bumps [github.com/deckarep/golang-set/v2](https://github.com/deckarep/golang-set) from 2.3.1 to 2.4.0.
- [Release notes](https://github.com/deckarep/golang-set/releases)
- [Commits](deckarep/golang-set@v2.3.1...v2.4.0)

---
updated-dependencies:
- dependency-name: github.com/deckarep/golang-set/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@github-actions @sebrandon1
Update RHCOS to OCP version map (redhat-best-practices-for-k8s#1659)
980606a 
Co-authored-by: sebrandon1 <[email protected]>
@github-actions @sebrandon1
Update RHCOS to OCP version map (redhat-best-practices-for-k8s#1660)
a399225 
Co-authored-by: sebrandon1 <[email protected]>
@github-actions @sebrandon1
Update RHCOS to OCP version map (redhat-best-practices-for-k8s#1661)
bfb8e98 
Co-authored-by: sebrandon1 <[email protected]>
@dependabot @greyerof
Bump github.com/operator-framework/api from 0.19.0 to 0.20.0 (redhat-…
679020f 
…best-practices-for-k8s#1657)

Bumps [github.com/operator-framework/api](https://github.com/operator-framework/api) from 0.19.0 to 0.20.0.
- [Release notes](https://github.com/operator-framework/api/releases)
- [Changelog](https://github.com/operator-framework/api/blob/master/RELEASE.md)
- [Commits](operator-framework/api@v0.19.0...v0.20.0)

---
updated-dependencies:
- dependency-name: github.com/operator-framework/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gonzalo Reyero Ferreras <[email protected]>
@edcdavid
Allow cluster role bindings for pods ultimately owned by a cluster wi…
08d0fb9 
…de operator (redhat-best-practices-for-k8s#1646)

* Recursively get top pod owners.
If top owner is a CSV installed cluster-wide, allow cluster role-bindings

* Addressing comments from Gonzalo

* Adding unit testing (comment from Brandon)
@edcdavid
Add-batch-cert-script (redhat-best-practices-for-k8s#1604)
b8f2818 
* Script to batch check operators

* installing operators using tasty😋(https://github.com/karmab/tasty) instead of operator SDK

* Addressing comments from David R. and other fixes
@github-actions @sebrandon1
Update RHCOS to OCP version map (redhat-best-practices-for-k8s#1669)
4bc9590 
Co-authored-by: sebrandon1 <[email protected]>
@dependabot
Bump github.com/onsi/ginkgo/v2 from 2.13.1 to 2.13.2 (redhat-best-pra…
c6af662 
…ctices-for-k8s#1671)

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.13.1 to 2.13.2.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.13.1...v2.13.2)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
bnshr and others added 24 commits December 4, 2023 12:09
@bnshr
Fix WG done call (redhat-best-practices-for-k8s#1688)
11c322f
@sebrandon1
Remove GPL commitment (redhat-best-practices-for-k8s#1689)
14faa1c
@dependabot
Bump github.com/test-network-function/privileged-daemonset (redhat-be…
2cbc8bf 
…st-practices-for-k8s#1695)

Bumps [github.com/test-network-function/privileged-daemonset](https://github.com/test-network-function/privileged-daemonset) from 1.0.15 to 1.0.16.
- [Release notes](https://github.com/test-network-function/privileged-daemonset/releases)
- [Commits](redhat-best-practices-for-k8s/privileged-daemonset@v1.0.15...v1.0.16)

---
updated-dependencies:
- dependency-name: github.com/test-network-function/privileged-daemonset
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@sebrandon1
Update Go to v1.21.5 (redhat-best-practices-for-k8s#1697)
d90d834
@dependabot
Bump actions/setup-go from 4 to 5 (redhat-best-practices-for-k8s#1700)
b97140c 
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@github-actions @sebrandon1
Update RHCOS to OCP version map (redhat-best-practices-for-k8s#1705)
b524770 
Co-authored-by: sebrandon1 <[email protected]>
@rdavid
The find command requires a directory as the first argument (redhat-b…
ac85eb0 
…est-practices-for-k8s#1709)
@rdavid
Add operator versions (redhat-best-practices-for-k8s#1708)
9dd9569 
* Add operator versions

* Fix the indentation
@edcdavid
extracts results.html from tar.gz and debug mode (redhat-best-practic…
4fd9a03 
…es-for-k8s#1706)

* extracts results.html from tar.gz and debug mode

* Addressing comment from David R.
@edcdavid
Updating Telco list (redhat-best-practices-for-k8s#1712)
19f0ed1
@edcdavid
skip operator if claim file couldn't be parsed (redhat-best-practices…
e09c4bb 
…-for-k8s#1714)

* skip operator if claim file couldn't be parsed
* addressing comments from David R.
@dependabot
Bump github/codeql-action from 2 to 3 (redhat-best-practices-for-k8s#…
2a5158a 
…1722)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@v2...v3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@sebrandon1
Enable QE nightlies for ginkgo_removal (redhat-best-practices-for-k8s…
82d3442 
…#1723)
@sebrandon1
Revert "Enable QE nightlies for ginkgo_removal (redhat-best-practices…
8f517ba 
…-for-k8s#1723)" (redhat-best-practices-for-k8s#1724)

This reverts commit 82d3442.
@dependabot
Bump actions/upload-artifact from 3 to 4 (redhat-best-practices-for-k…
1c3dc05 
…8s#1729)

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump helm.sh/helm/v3 from 3.13.2 to 3.13.3 (redhat-best-practices-for…
d5204d4 
…-k8s#1735)

Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.13.2 to 3.13.3.
- [Release notes](https://github.com/helm/helm/releases)
- [Commits](helm/helm@v3.13.2...v3.13.3)

---
updated-dependencies:
- dependency-name: helm.sh/helm/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@aabughosh
to add a msg about the k8s bug (redhat-best-practices-for-k8s#1720)
a86a981 
* to add a msg about the k8s bug

* Update suite.go

* Update suite.go
@dependabot
Bump github.com/test-network-function/privileged-daemonset (redhat-be…
90a5f43 
…st-practices-for-k8s#1742)

Bumps [github.com/test-network-function/privileged-daemonset](https://github.com/test-network-function/privileged-daemonset) from 1.0.16 to 1.0.18.
- [Release notes](https://github.com/test-network-function/privileged-daemonset/releases)
- [Commits](redhat-best-practices-for-k8s/privileged-daemonset@v1.0.16...v1.0.18)

---
updated-dependencies:
- dependency-name: github.com/test-network-function/privileged-daemonset
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@github-actions @sebrandon1
Update RHCOS to OCP version map (redhat-best-practices-for-k8s#1743)
ee7807c 
Co-authored-by: sebrandon1 <[email protected]>
@github-actions @sebrandon1
Update RHCOS to OCP version map (redhat-best-practices-for-k8s#1744)
7ccf1a4 
Co-authored-by: sebrandon1 <[email protected]>
@edcdavid
Fix for fatal error in diagnostics (redhat-best-practices-for-k8s#1715)…
ae04021 
… (redhat-best-practices-for-k8s#1740)
@dependabot
Bump github.com/mittwald/go-helm-client from 0.12.4 to 0.12.5 (redhat…
a21238f 
…-best-practices-for-k8s#1746)

Bumps [github.com/mittwald/go-helm-client](https://github.com/mittwald/go-helm-client) from 0.12.4 to 0.12.5.
- [Release notes](https://github.com/mittwald/go-helm-client/releases)
- [Commits](mittwald/go-helm-client@v0.12.4...v0.12.5)

---
updated-dependencies:
- dependency-name: github.com/mittwald/go-helm-client
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump golang.org/x/crypto from 0.15.0 to 0.17.0 (redhat-best-practices…
455016e 
…-for-k8s#1749)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.15.0 to 0.17.0.
- [Commits](golang/crypto@v0.15.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@greyerof
Merge branch 'main' into ginkgo_removal
910e40b
@greyerof greyerof merged commit 0cc22e0 into redhat-best-practices-for-k8s:ginkgo_removal Dec 19, 2023
7 checks passed
@sebrandon1 sebrandon1 mentioned this pull request Dec 19, 2023
Merged
@greyerof greyerof deleted the ginkgo_removal_merge_main branch January 2, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edcdavid edcdavid edcdavid approved these changes

@sebrandon1 sebrandon1 sebrandon1 approved these changes

Assignees
No one assigned
Labels
ginkgoless
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@greyerof @sebrandon1 @edcdavid @jmontesi @shirmoran @rdavid @bnshr @aabughosh