Remove free disk space cleanup #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdavid
reviewed
Jan 18, 2024
rdavid
approved these changes
Jan 18, 2024
sebrandon1
force-pushed
the
remove_disk_space_cleanup
branch
from
2054c1b to
f481d4a
Compare
|
/dci-rerun |
1 similar comment
|
/dci-rerun |
sebrandon1
force-pushed
the
remove_disk_space_cleanup
branch
from
f481d4a to
3336428
Compare
sebrandon1
force-pushed
the
remove_disk_space_cleanup
branch
from
3336428 to
ec39288
Compare
|
Seems to work if I add our env variable: |
sebrandon1
merged commit cb4fb36
into
redhat-best-practices-for-k8s:main
20 checks passed
sebrandon1
added a commit
that referenced
this pull request
Feb 5, 2024
This reverts commit cb4fb36.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the size of the virtual disks of the free tier is doubled, I'm testing whether or not we need these disk space cleanups anymore to speed up our runs.
See: https://github.blog/2024-01-17-github-hosted-runners-double-the-power-for-open-source/