Add functionality for running against local CRC instances #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebrandon1
force-pushed
the
add_crc_support
branch
from
063c60b to
974f7bf
Compare
sebrandon1
force-pushed
the
add_crc_support
branch
from
974f7bf to
deb4508
Compare
|
from change #1843: |
rdavid
reviewed
Jan 26, 2024
Comment on lines
+163
to
+166
| if [ -n "${TNF_ENABLE_CRC_TESTING}" ]; then | ||
| ADD_HOST_ARG="--add-host api.crc.testing:host-gateway" | ||
| fi | ||
|
|
There was a problem hiding this comment.
Suggested change
| if [ -n "${TNF_ENABLE_CRC_TESTING}" ]; then | |
| ADD_HOST_ARG="--add-host api.crc.testing:host-gateway" | |
| fi | |
| ADD_HOST_ARG="${TNF_ENABLE_CRC_TESTING:+--add-host api.crc.testing:host-gateway}" | |
ADD_HOST_ARG will be assigned --add... value if TNF_ENABLE_CRC_TESTING is set, otherwise ''. Currently if TNF_ENABLE_CRC_TESTING is unset $ADD_HOST_ARG fails when executed with set -o nounset, which is recommended. This can be addressed in a separate pull request for all variables.
rdavid
approved these changes
Jan 26, 2024
|
Let's just adjust what you suggested for all of the other similar instances above in another PR. |
sebrandon1
merged commit 74135ce
into
redhat-best-practices-for-k8s:main
19 checks passed
|
from change #1843: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developers.redhat.com/products/openshift-local/overview
If you are running an instance of OpenShift Local (formerly CodeReady Containers) on your local machine and want to run the containerized version of the test suite against it, you have to use
--add-hostfor the container to be able reach the apiserver correctly.