enable changing cnf suites timeout using env var #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirmoran
force-pushed
the
timeout-modification-run-cnf-suites
branch
from
fa4d44c to
71a860a
Compare
|
from change #1846: |
rdavid
approved these changes
Jan 30, 2024
jmontesi
approved these changes
Jan 31, 2024
shirmoran
merged commit fa78c84
into
redhat-best-practices-for-k8s:main
19 checks passed
|
from change #1846: |
shirmoran
added a commit
to redhat-best-practices-for-k8s/certsuite-operator
that referenced
this pull request
Jan 31, 2024
…suites (#13) Together with the modification of run-cnf-suites.sh in cnf repo ([PR#1846](redhat-best-practices-for-k8s/certsuite#1846)), setting Run CR's timeout field as an env var in the container running the test suites, will allow modifying default timeout to the given.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running cnf cert operator we want to allow setting cnf suites run's timeout.
With this change we enable setting timeout using an environment variable.