Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify network interface for ICMP tests #1853

Conversation

sebrandon1
Copy link
Member

Changes include:

  • Changing MultusIPs: map[string][]string to MultusNetworkInterfaces: map[string][]provider.CniNetworkInterface.
  • Making provider.CniNetworkInterface struct public.
  • Modifying the TestPing() func to accept interface name.

@sebrandon1 sebrandon1 self-assigned this Feb 1, 2024
@sebrandon1 sebrandon1 force-pushed the icmp_specific_interface branch from 55fd978 to b278fdb Compare February 1, 2024 14:52
@dcibot
Copy link
Collaborator

dcibot commented Feb 1, 2024

@dcibot
Copy link
Collaborator

dcibot commented Feb 1, 2024

pkg/provider/provider.go Outdated Show resolved Hide resolved
@sebrandon1 sebrandon1 force-pushed the icmp_specific_interface branch from 78777da to 0371464 Compare February 2, 2024 15:39
@dcibot
Copy link
Collaborator

dcibot commented Feb 2, 2024

@sebrandon1 sebrandon1 force-pushed the icmp_specific_interface branch from 0371464 to 784777f Compare February 2, 2024 16:37
@dcibot
Copy link
Collaborator

dcibot commented Feb 2, 2024

@sebrandon1 sebrandon1 force-pushed the icmp_specific_interface branch from 784777f to 7f68199 Compare February 2, 2024 21:14
@dcibot
Copy link
Collaborator

dcibot commented Feb 2, 2024

@sebrandon1 sebrandon1 force-pushed the icmp_specific_interface branch from 7f68199 to 6915dc3 Compare February 5, 2024 16:07
@dcibot
Copy link
Collaborator

dcibot commented Feb 5, 2024

@sebrandon1
Copy link
Member Author

/dci-rerun

@dcibot
Copy link
Collaborator

dcibot commented Feb 5, 2024

@sebrandon1 sebrandon1 merged commit 92041bd into redhat-best-practices-for-k8s:main Feb 5, 2024
18 of 19 checks passed
@sebrandon1 sebrandon1 deleted the icmp_specific_interface branch February 5, 2024 16:52
@dcibot
Copy link
Collaborator

dcibot commented Feb 5, 2024

@dcibot
Copy link
Collaborator

dcibot commented Feb 6, 2024

@dcibot
Copy link
Collaborator

dcibot commented Feb 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants