Avoid unnecessary rebuild of the test environment #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
from change #1919: |
The job is failing in the execution of tnf, so I believe this needs to be checked |
|
/dci-rerun |
|
from change #1919: |
sebrandon1
approved these changes
Mar 14, 2024
ramperher
requested changes
Mar 14, 2024
There was a problem hiding this comment.
tnf cannot be launched in our deployments, in this job: https://www.distributed-ci.io/jobs/0f0456cb-2996-4615-960f-f237cc09a5cd/files, in the Files section, you can take a look to dci-tnf-execution.log and cnf-certsuite.log to see the errors it is throwing. With this failure, this cannot be merged, else DCI jobs will all fail
The logs show that the test environment is built twice before starting running the test cases.
jmontesi
force-pushed
the
avoid_rebuilding_test_env
branch
from
60f29fb to
733492a
Compare
|
from change #1919: |
edcdavid
approved these changes
Mar 19, 2024
ramperher
approved these changes
Mar 20, 2024
|
from change #1919: |
jmontesi
merged commit b1a6e17
into
redhat-best-practices-for-k8s:main
19 checks passed
|
from change #1919: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logs show that the test environment is built twice before starting running the test cases, which should not be necessary. However, disabling this rebuild of the test environment lead to an error while marshaling the
TestConfigurationto JSON format. This PR refactors the way the Preflight test results are processed in order to produce an output of the test environment adequate for JSON marshaling without the need to rebuild it.The problem came with the direct addition of the struct
plibRuntime.Resultsinto ourContainerstruct. This former struct contains an interface that prevents the struct to be properly transformed to JSON. To solve this issue, another struct calledPreflightResultsDBthat only contains the information needed has been used instead.The test environment rebuild hid this problem because the Preflight results were cleared in the process, allowing the JSON marshaling to work correctly. The results could be retrieved later (even after being cleared) due to the fact that the old results were stored in the closure that contains the test function (defined in
WithCheckFn()).