Add --platform flag to Dockerfile #1940
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebrandon1
force-pushed
the
build_image_on_arm
branch
from
c89367e to
4edd932
Compare
|
from change #1940: |
|
So this works but it is extremely slow on my M-series CPU. I'm going to close this and see if I can build natively and see if that breaks anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.docker.com/build/building/multi-platform/
For now, we only really need to build the image with the platform
linux/amd64. The --platform flag allows the build to pass on M-series Mac's.EDIT: I had to add hadolint ignore's to the Dockerfile because the linter does not like the --platform flag.