Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multi-platform image builds #1942

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

sebrandon1
Copy link
Member

@sebrandon1 sebrandon1 commented Mar 27, 2024

Modifies the Dockerfile and the workflows to build correctly for each platform, arm64 and amd64.

There are two automation workflows:

  • .github/workflows/pre-main.yaml (creates the 'unstable' image)
  • .github/workflows/tnf-image.yaml (creates the tagged releases)

These are both now modified to build images for both arm64 and amd64 images, package them into a manifest, and then push to our registries.

When I tested this locally, you can see I created an image named bapalm/test-suite:v0.0.1:
image

It says "See Child Manifests".

If you expand on the child manifests you can see:
image

@sebrandon1 sebrandon1 self-assigned this Mar 27, 2024
@sebrandon1 sebrandon1 force-pushed the buildx branch 2 times, most recently from 69d3557 to b260618 Compare March 27, 2024 20:36
@dcibot
Copy link
Collaborator

dcibot commented Mar 27, 2024

@sebrandon1
Copy link
Member Author

@ramperher Can you take a look at this DCI job result?

task path: /usr/share/ansible/collections/ansible_collections/redhatci/ocp/roles/verify_tests/tasks/parse_junit_file.yml:37
fatal: [jumphost]: FAILED! => {"changed": false, "msg": "The following expectations failed: [{'failed_expectation': {'testcase': '^((?!networking-reserved-partner-ports|access-control-security-context|platform-alteration-tainted-node-kernel|affiliated-certification-container-is-certified-digest|preflight-HasUniqueTag|preflight-ScorecardBasicSpecCheck|preflight-RequiredAnnotations|preflight-ScorecardOlmSuiteCheck).)*$', 'passed': True}, 'actual_result': {'testcase': 'affiliated-certification-helmchart-is-certified', 'passed': False}}]"}

Dockerfile Show resolved Hide resolved
@sebrandon1 sebrandon1 merged commit 00eb8a7 into redhat-best-practices-for-k8s:main Mar 28, 2024
18 of 19 checks passed
@sebrandon1 sebrandon1 deleted the buildx branch March 28, 2024 14:07
sebrandon1 added a commit that referenced this pull request Mar 28, 2024
sebrandon1 added a commit that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants