-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable multi-platform image builds #1942
Merged
sebrandon1
merged 1 commit into
redhat-best-practices-for-k8s:main
from
sebrandon1:buildx
Mar 28, 2024
Merged
Enable multi-platform image builds #1942
sebrandon1
merged 1 commit into
redhat-best-practices-for-k8s:main
from
sebrandon1:buildx
Mar 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69d3557
to
b260618
Compare
from change #1942: |
@ramperher Can you take a look at this DCI job result?
|
rdavid
reviewed
Mar 27, 2024
rdavid
reviewed
Mar 27, 2024
edcdavid
approved these changes
Mar 27, 2024
rdavid
approved these changes
Mar 28, 2024
00eb8a7
into
redhat-best-practices-for-k8s:main
18 of 19 checks passed
sebrandon1
added a commit
that referenced
this pull request
Mar 28, 2024
This reverts commit 00eb8a7.
sebrandon1
added a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the Dockerfile and the workflows to build correctly for each platform, arm64 and amd64.
There are two automation workflows:
.github/workflows/pre-main.yaml
(creates the 'unstable' image).github/workflows/tnf-image.yaml
(creates the tagged releases)These are both now modified to build images for both arm64 and amd64 images, package them into a manifest, and then push to our registries.
When I tested this locally, you can see I created an image named
![image](https://private-user-images.githubusercontent.com/4563082/317495427-c4948cd6-7207-46be-84ed-5657d7a39768.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzODA3MzQsIm5iZiI6MTczOTM4MDQzNCwicGF0aCI6Ii80NTYzMDgyLzMxNzQ5NTQyNy1jNDk0OGNkNi03MjA3LTQ2YmUtODRlZC01NjU3ZDdhMzk3NjgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTJUMTcxMzU0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YWQ0NDA4N2M5MGYxYmU4NzJlNjIxYzFjNmFmMTU1NDYzODdmYTI5YWJiMzRjZGVhNGJkYzAwMjJlYzVmYmU2MyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.I-ZjVQLi2TASZqNgYGcXCkatOIxsv3XMkMM0BdTaxmU)
bapalm/test-suite:v0.0.1
:It says "See Child Manifests".
If you expand on the child manifests you can see:
![image](https://private-user-images.githubusercontent.com/4563082/317495553-2ac38b1d-4bfb-4be7-9280-bc7fc9a681a7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzODA3MzQsIm5iZiI6MTczOTM4MDQzNCwicGF0aCI6Ii80NTYzMDgyLzMxNzQ5NTU1My0yYWMzOGIxZC00YmZiLTRiZTctOTI4MC1iYzdmYzlhNjgxYTcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTJUMTcxMzU0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YzIxYWFiNmU3ZmQxOGE4ZTZhZjE0OTlmZDQ4MmY0MDY1MThmNjJmZTY2Y2IwMDQ1MDllM2U2NjAwZGMxZDA5YSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.-YZLxG1tR8BhxsK4IvtD87MAOqbO5YDHqV50f7MFuEM)