[StepSecurity] Apply security best practices #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| jobs: | ||
| update-certification: | ||
| permissions: | ||
| contents: write # for peter-evans/create-pull-request to create branch |
Check failure
Code scanning / Scorecard
Token-Permissions
|
from change #2011: |
edcdavid
force-pushed
the
stepsecurity_remediation_1714077827
branch
from
d3fb5c0 to
8e1fbf9
Compare
|
Interesting, does this work well with dependabot? |
|
from change #2011: |
Do you mean to lock it in with the SHA? If yes, I am not sure. We would probably need to let in run for real for some time |
|
from change #2011: |
|
from change #2011: |
edcdavid
force-pushed
the
stepsecurity_remediation_1714077827
branch
from
b921df4 to
40adf47
Compare
|
from change #2011: |
Signed-off-by: StepSecurity Bot <[email protected]>
edcdavid
force-pushed
the
stepsecurity_remediation_1714077827
branch
from
66ba312 to
b5d0357
Compare
sebrandon1
approved these changes
Apr 26, 2024
|
from change #2011: |
edcdavid
merged commit 180eb0e
into
redhat-best-practices-for-k8s:main
20 checks passed
|
from change #2011: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR our OSS scorecard jumps from 6.3 to 10
Summary
This pull request is created by StepSecurity at the request of @edcdavid. Please merge the Pull Request to incorporate the requested changes. Please tag @edcdavid on your message if you have any questions related to the PR.
Security Fixes
Least Privileged GitHub Actions Token Permissions
The GITHUB_TOKEN is an automatically generated secret to make authenticated calls to the GitHub API. GitHub recommends setting minimum token permissions for the GITHUB_TOKEN.
Pinned Dependencies
GitHub Action tags and Docker tags are mutable. This poses a security risk. GitHub's Security Hardening guide recommends pinning actions to full length commit.
Keeping your actions up to date with Dependabot
With Dependabot version updates, when Dependabot identifies an outdated dependency, it raises a pull request to update the manifest to the latest version of the dependency. This is recommended by GitHub as well as The Open Source Security Foundation (OpenSSF).
Secure Dockerfiles
Pin image tags to digests in Dockerfiles. With the Docker v2 API release, it became possible to use digests in place of tags when pulling images or to use them in FROM lines in Dockerfiles.
Feedback
For bug reports, feature requests, and general feedback; please email [email protected]. To create such PRs, please visit https://app.stepsecurity.io/securerepo.
Signed-off-by: StepSecurity Bot [email protected]