-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WaitingForRelease feature flag #2614
Add WaitingForRelease feature flag #2614
Conversation
7a58f49
to
aa58650
Compare
from change #2614: |
87cc621
to
427df3a
Compare
from change #2614: |
427df3a
to
b8dbfc9
Compare
This is probably going to fail DCI until they add the environment variable. Right now I have it set as This environment variable (whatever we decide on) will probably also have to be set on developer machines who are attempting to run the |
from change #2614: |
b8dbfc9
to
41852ef
Compare
from change #2614: |
Just my two cents here: if a test case made it (after the review+approval process) to the main branch, it is then supposed to be fully functional and, at least, it should have been manually tested, so appearing in the catalog as a new official test case in the next release cut seems 100% legit to me in that case. Why should we hide them and wait for some X.Y.Z release to announce all of them at once? In case we want/need to go with half-baked test cases, why not just flag them with some extra label like that "waiting-for-release" or similar ("release-pending", "not-released", "in-progress"...)? It should be sufficient to state in our official documentation that the results of those test cases, whether they pass or fail, should not be considered official, as they are not officially released/supported yet. Just removing that label when they're 100% ready or before the release cut should work. Adding extra env vars shouldn't be necessary. |
That's fair. There's nothing "wrong" with just releasing what we currently have merged into In the meantime, I think I will just release |
As of right now, when we are adding new tests to the repo we can't really release a new version of the certsuite until everything has been merged in. This will allow us to set tests as disabled and they won't affect existing release version of the certsuite.
Changes:
WaitingForRelease
tag similar toTagCommon
,TagTelco
, etc.WaitingFoRelease
added to them. This removes their entries from the CATALOG.md temporarily until we are ready to fully release them to partners.To keep the tests enabled in our CI's we are setting an environment variable
REDHAT_CI
which will always set the test cases to enabled regardless of `waiting-for-release" tag.