Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update preflight to v1.11.1 #2648

Merged

Conversation

sebrandon1
Copy link
Member

@sebrandon1 sebrandon1 commented Dec 17, 2024

@sebrandon1 sebrandon1 self-assigned this Dec 17, 2024
@dcibot
Copy link
Collaborator

dcibot commented Dec 17, 2024

@sebrandon1
Copy link
Member Author

@ramperher This new update to preflight v1.11.1 adds a new test which is failing in the DCI run:

'actual_result': {'testcase': 'preflight-HasRequiredLabel', 'passed': False}}]"}

@itroyano
Copy link

The good news is the new test ran :)

@ramperher
Copy link
Collaborator

@ramperher This new update to preflight v1.11.1 adds a new test which is failing in the DCI run:

'actual_result': {'testcase': 'preflight-HasRequiredLabel', 'passed': False}}]"}

I've added an exception for this test in our pipeline, but note we're testing your sample workload in all these jobs, so if this test is failing, this means your workload needs to be updated to pass this test, and also the other one that is failing, which is preflight-HasUniqueTag.

@dcibot
Copy link
Collaborator

dcibot commented Dec 19, 2024

@ramperher
Copy link
Collaborator

/dci-rerun

@itroyano
Copy link

itroyano commented Dec 19, 2024

cc: @acornett21 @komish
Looks like a test image that doesn't set a "maintainer" label, sets the name at "Red Hat", or both.

@dcibot
Copy link
Collaborator

dcibot commented Dec 19, 2024

@sebrandon1 sebrandon1 merged commit 87d584d into redhat-best-practices-for-k8s:main Dec 19, 2024
34 checks passed
@sebrandon1 sebrandon1 deleted the preflight_update branch December 19, 2024 16:59
@dcibot
Copy link
Collaborator

dcibot commented Dec 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants