CSVs autodiscovery fix. #2653
Merged
CSVs autodiscovery fix. #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR redhat-best-practices-for-k8s#2479 fixed the autodiscovery of operator's pods and also added them to the pods-under-test list. The problem is that it was also adding every cluster-wide operator's controller pods to that list. With this change, the operator (controller's pod) must be running in one of the configured/test namespaces in order to consider that CSV as part of the operators under test.
|
from change #2653: |
edcdavid
approved these changes
Dec 18, 2024
bnshr
approved these changes
Dec 19, 2024
greyerof
added a commit
to redhat-best-practices-for-k8s/certsuite-qe
that referenced
this pull request
Dec 19, 2024
Certsuite's PR redhat-best-practices-for-k8s/certsuite#2653 changed the way CSVs are autodiscovered in order for operator pods to be tested: the operator installation namespace must be explicitly added to the configured namespaces. This change deploys the operatorgroup and subscription of the logging operator in the random test namespace that is set in the certsuite confi file.
The ref points to the branch of this QE fix: redhat-best-practices-for-k8s/certsuite-qe#1032
|
from change #2653: |
sebrandon1
approved these changes
Dec 19, 2024
greyerof
added a commit
to redhat-best-practices-for-k8s/certsuite-qe
that referenced
this pull request
Dec 20, 2024
Certsuite's PR redhat-best-practices-for-k8s/certsuite#2653 changed the way CSVs are autodiscovered in order for operator pods to be tested: the operator installation namespace must be explicitly added to the configured namespaces. This change deploys the operatorgroup and subscription of the logging operator in the random test namespace that is set in the certsuite confi file.
As QE PR redhat-best-practices-for-k8s/certsuite-qe#1032 has been merged, this PR should work with QE main branch now. This reverts commit 430bba5.
|
from change #2653: |
greyerof
merged commit 9f1ebd9
into
redhat-best-practices-for-k8s:main
34 of 35 checks passed
|
from change #2653: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2479 fixed the autodiscovery of operator's pods and also added them to the pods-under-test list. The problem is that, when using namespace discovery mode, it was also adding every cluster-wide operator's controller pods to that list.
With this change, the operator (controller's pod) must be running in one of the configured/test namespaces in order to consider that CSV as part of the operators under test.