New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring + S3 Upload #89

Merged

shirmoran merged 13 commits into main from s3_upload

Jan 8, 2024

Contributor

bnshr commented Dec 12, 2023

No description provided.

bnshr marked this pull request as draft

December 12, 2023 20:09

bnshr force-pushed the s3_upload branch from 5717f0a to d00bc5f Compare

December 12, 2023 20:40


          Refactoring

1826d70

Includes better structuring of the packages
Transaction is started as the last step
Environment variables retrieval is safer now
Utils functions are grouped

bnshr force-pushed the s3_upload branch 2 times, most recently from f3511e1 to 1ae0065 Compare

December 13, 2023 15:11


          Refactoring

4252bc9

bnshr force-pushed the s3_upload branch from 1ae0065 to 4252bc9 Compare

December 13, 2023 15:17

shirmoran reviewed

View reviewed changes

api/validator.go Outdated Show resolved Hide resolved

shirmoran reviewed

View reviewed changes

api/validator.go Outdated Show resolved Hide resolved

shirmoran reviewed

View reviewed changes

util/http_utils.go Outdated Show resolved Hide resolved

shirmoran reviewed

View reviewed changes

util/http_utils.go Outdated Show resolved Hide resolved

shirmoran reviewed

View reviewed changes

api/auth.go Outdated Show resolved Hide resolved

shirmoran reviewed

View reviewed changes

util/db_utils.go Outdated Show resolved Hide resolved

shirmoran reviewed

View reviewed changes

api/parser_handler.go Outdated Show resolved Hide resolved

bnshr force-pushed the s3_upload branch 4 times, most recently from 0a5db1a to 43d5ac3 Compare

December 14, 2023 15:19


          Fix password valdiation for the partner

24341ac

bnshr force-pushed the s3_upload branch from 43d5ac3 to 24341ac Compare

December 14, 2023 15:25

bnshr added 2 commits

December 14, 2023 16:29


          Address review comments

5d907ac


          Fix linter

9f02cf4

sebrandon1 reviewed

View reviewed changes

api/result_handler.go Show resolved Hide resolved


          Modify the retrieval of S3 access

f9d1b4e

shirmoran self-assigned this

shirmoran added 2 commits

January 2, 2024 11:09


          change default DB env vars to match CI DB credentials

cff5e2a


          linting changes

fdf36b1

sebrandon1 marked this pull request as ready for review

January 2, 2024 22:27

Member

sebrandon1 commented Jan 2, 2024

I changed it from Draft to Ready for Review.


          adjust parser to new claim file version

b3baf7d


          enabled file upload to bucket

9f4f040

shirmoran force-pushed the s3_upload branch 2 times, most recently from f055568 to 452b717 Compare

January 4, 2024 15:33


          linting changes

57c01c5

shirmoran force-pushed the s3_upload branch from 452b717 to 57c01c5 Compare

January 4, 2024 15:36

sebrandon1 approved these changes

View reviewed changes

Member

sebrandon1 left a comment

Some minor things, but looks good!

api/parser_handler.go Outdated Show resolved Hide resolved

api/validator.go Outdated Show resolved Hide resolved


          Update api/parser_handler.go

c2dfd0f

Co-authored-by: Brandon Palm <[email protected]>

shirmoran force-pushed the s3_upload branch 2 times, most recently from c78706e to 7b6ea2f Compare

January 8, 2024 08:16


          Update api/validator.go

d370dcf

Co-authored-by: Brandon Palm <[email protected]>

shirmoran force-pushed the s3_upload branch from 7b6ea2f to d370dcf Compare

January 8, 2024 08:40

shirmoran merged commit 26fd6f7 into main

3 checks passed

sebrandon1 deleted the s3_upload branch

February 29, 2024 19:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet