Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples pass ansible-lint. #111

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Examples pass ansible-lint. #111

merged 1 commit into from
Apr 25, 2024

Conversation

jeffmcutter
Copy link
Contributor

No description provided.

djdanielsson
djdanielsson requested changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick skim and I think at least this one playbook is supposed to not be the way to do it so I am not sure if we care or want it to pass lint? Just a thought, I am not sure if there are any others like this it was the only one I noticed.

inventories/inventory_loop_hosts/playbook_bad.yml
@@ -1,12 +1,14 @@
- name: provision hosts in a bad way
- name: Provision hosts in a bad way
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this playbook is supposed to be bad so maybe it shouldn't pass lint?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered that as well, but was thinking the focus was more around the approach to the problem than about the formatting of the file. I can change it back if we want.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericzolf what is your opinion here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Jeff, let's keep it 100% clean unless we have a very good reason (or the next person going through this exercise will trip over it).

ericzolf
ericzolf approved these changes Apr 17, 2024
View reviewed changes
inventories/inventory_loop_hosts/playbook_bad.yml
@@ -1,12 +1,14 @@
- name: provision hosts in a bad way
- name: Provision hosts in a bad way
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Jeff, let's keep it 100% clean unless we have a very good reason (or the next person going through this exercise will trip over it).

djdanielsson
djdanielsson approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffmcutter jeffmcutter merged commit 257dabb into redhat-cop:main Apr 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djdanielsson djdanielsson djdanielsson approved these changes

@ericzolf ericzolf ericzolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffmcutter @ericzolf @djdanielsson