chore(E2E): Make sure the E2E tests can fully test that the application is reachable on K8s (using an Ingress on GH) #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rm3l
force-pushed
the
devweek/012025/ci_e2e_on_k8s_using_ingress
branch
from
289c8ff to
a6ce537
Compare
…on is reachable on K8s (using an Ingress on GH) This is a gap I wanted to close with the current nightly checks. On OCP, the tests ensure access via the Route created by the Operator, but on K8s (like here in GH against Minikube), this would just be skipped. In a few situations, I had to manually run the tests against OCP to check that everything worked as expected from a user standpoint. Without waiting for issues.redhat.com/browse/RHIDP-2176 to be implemented, this tries to check such access at least, mainly because that's also how we instruct our users on managed K8s clusters to access their Operator-backed instances. This way, the test can create an Ingress Resource and ensure the application is fully reachable, using the same steps an end-user would perform to make expose their Operator-backed app.
rm3l
force-pushed
the
devweek/012025/ci_e2e_on_k8s_using_ingress
branch
from
a6ce537 to
431fb74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a gap I wanted to close with the current nightly checks.
On OCP, the tests ensure access via the Route created by the Operator, but on K8s (like here in GH against Minikube), this would just be skipped.
In a few situations, I had to manually run the tests against OCP to check that everything worked as expected from a user standpoint.
Without waiting for https://issues.redhat.com/browse/RHIDP-2176 to be implemented, this tries to check such access at least, mainly because that's also how we instruct our users on managed K8s clusters to access their Operator-backed instances.
Which issue(s) does this PR fix or relate to
PR acceptance criteria
How to test changes / Special notes to the reviewer
Example of a successful run with the changes here: https://github.com/rm3l/redhat-developer-hub-operator/actions/runs/12877252854