Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(global-header): added config for default header components #2263

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ciiay
Copy link
Contributor

@ciiay ciiay commented Jan 27, 2025

Description

  • Added config for default application header components
  • Added extra common icons
  • Updated support to "tech-preview"

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

  1. Pull changes in rhdh-plugins PR to your local and in workspaces/global-header/plugins/global-header/ directory run npx --yes @janus-idp/cli package export-dynamic-plugin --dynamic-plugins-root <path-to-your-rhdh>/dynamic-plugins-root --dev
  2. Pull changes in this PR to your local rhdh, in app-config.local file:
dynamicPlugins:
  rootDirectory: dynamic-plugins-root
  frontend:
    red-hat-developer-hub.backstage-plugin-global-header:
      mountPoints:
        - mountPoint: application/header
          importName: GlobalHeader
          config:
            layout:
              position: above-main-content
              # position: above-sidebar
        - mountPoint: application/header/component
          importName: SearchComponent
          config:
            type: search
            enabled: true
            slot: header-start
            priority: 100
        - mountPoint: application/header/component
          importName: CreateDropdown
          config:
            type: dropdown_button
            enabled: true
            key: create
            slot: header-start
            priority: 90
        - mountPoint: application/header/component
          importName: HeaderIconButton
          config:
            type: icon_button
            enabled: true
            slot: header-start
            priority: 80
            props:
              icon: support
              tooltip: Support
        - mountPoint: application/header/component
          importName: HeaderIconButton
          config:
            type: icon_button
            enabled: true
            slot: header-start
            priority: 70
            props:
              icon: notifications
              tooltip: Notifications
        - mountPoint: application/header/component
          importName: ProfileDropdown
          config:
            type: dropdown_button
            enabled: true
            key: profile
            slot: header-end
            priority: 0

Note: "support" and "notifications" are just for UI display for now.

Screen recording:

rhidp_5252.mp4

Copy link

openshift-ci bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rm3l for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ciiay ciiay requested review from debsmita1 and removed request for dzemanov January 27, 2025 21:02
Copy link
Contributor

@ciiay
Copy link
Contributor Author

ciiay commented Jan 28, 2025

/test e2e-tests

@ciiay ciiay force-pushed the rhidp-5252-add-default-header-components branch from 3c47b55 to bd34619 Compare January 28, 2025 18:18
Copy link
Contributor

@ciiay ciiay force-pushed the rhidp-5252-add-default-header-components branch 2 times, most recently from f54e4ea to b6c9481 Compare January 29, 2025 06:33
Copy link
Contributor

@ciiay ciiay force-pushed the rhidp-5252-add-default-header-components branch from 174e308 to 9439980 Compare January 29, 2025 14:22
Copy link
Contributor

Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant