-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(global-header): added config for default header components #2263
base: main
Are you sure you want to change the base?
feat(global-header): added config for default header components #2263
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The image is available at: |
/test e2e-tests |
3c47b55
to
bd34619
Compare
The image is available at: |
f54e4ea
to
b6c9481
Compare
The image is available at: |
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
174e308
to
9439980
Compare
The image is available at: |
Signed-off-by: Yi Cai <[email protected]>
The image is available at: |
Description
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer
workspaces/global-header/plugins/global-header/
directory runnpx --yes @janus-idp/cli package export-dynamic-plugin --dynamic-plugins-root <path-to-your-rhdh>/dynamic-plugins-root --dev
app-config.local
file:Note: "support" and "notifications" are just for UI display for now.
Screen recording:
rhidp_5252.mp4