Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: misc wrapper fixes #2268

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: misc wrapper fixes #2268

wants to merge 1 commit into from

Conversation

04kash
Copy link
Collaborator

@04kash 04kash commented Jan 28, 2025

Description

  • Added missing turbo.json file to red-hat-developer-hub-backstage-plugin-global-header
  • Updated supported version to 1.35.0 in red-hat-developer-hub-backstage-plugin-marketplace-backend-dynamic

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from 04kash. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@04kash 04kash force-pushed the misc-fixes branch 2 times, most recently from 72d46af to 04724c0 Compare January 28, 2025 17:08
Copy link
Contributor

Signed-off-by: Kashish Mittal <[email protected]>
Copy link
Contributor

@04kash
Copy link
Collaborator Author

04kash commented Jan 30, 2025

/retest

1 similar comment
@04kash
Copy link
Collaborator Author

04kash commented Jan 30, 2025

/retest

Copy link

openshift-ci bot commented Jan 30, 2025

@04kash: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 76cd1a0 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant