Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added December What's New #433

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

mportman12
Copy link
Collaborator

No description provided.

@mportman12
Copy link
Collaborator Author

@bergerhoffer please review

Copy link
Collaborator

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things!

== December 2023
.Glossary entries
* xref:ibm-cloud[IBM Cloud®]: Added glossary entry
* xref:now[now]: Updated glossary entry to "use with caution"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is out of alphabetical order

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

supplementary_style_guide/introduction/whats-new.adoc Outdated Show resolved Hide resolved
@bergerhoffer bergerhoffer added the General update General updates to the guide or repo label Jan 9, 2024
@mportman12
Copy link
Collaborator Author

@bergerhoffer Made your fixes, please review again

Copy link
Collaborator

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mportman12 the actual update lgtm, but the vale check is failing. Not sure what is going on with that - CC @aireilly / @bburt-rh

@aireilly
Copy link
Member

Oh there is a breaking failure with the latest version of Vale. Will submit a fix presently.

@bergerhoffer
Copy link
Collaborator

Oh there is a breaking failure with the latest version of Vale. Will submit a fix presently.

Thanks @aireilly!

@aireilly
Copy link
Member

@bergerhoffer PTAL and merge: #435

This PR fixes the Vale issue.

@mportman12 mportman12 merged commit 57d69e7 into redhat-documentation:main Jan 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General update General updates to the guide or repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants