Doing a sweep to add {nbsp} between 'Red' and 'Hat' throughout repo #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergerhoffer
force-pushed
the
nbsp-sweep
branch
from
131bcf7 to
508011c
Compare
|
Please ignore the failed vale check here |
bergerhoffer
force-pushed
the
nbsp-sweep
branch
from
508011c to
59446ac
Compare
|
Thanks, @bergerhoffer . LGTM. Excellent work!
|
dfitzmau
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this sweep because of this comment: #445 (comment)
Looks like we never did a full sweep of fixing this throughout the repo.
Preview: https://file.rdu.redhat.com/~ahoffer/2024/main-nbsp.html
You can see in this example the "Directory Server" entry is bumped to the next line to keep "Red Hat" together.