Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update grammar.adoc with guidance on inanimate users #495
Update grammar.adoc with guidance on inanimate users #495
Changes from 9 commits
e9e888b
815ebd1
408ce1d
c5b3a93
5d19658
7c32e1f
550cbc7
cceea76
6ecce61
ab68a3b
49a4b82
2b04791
4456325
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking out aloud here. Do we want to differentiate them like the "task performer" vs "role references"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I'm not sure I understand what you mean here.
Do you mean that we sometimes refer to "users" as those who perform the tasks (i.e. reader)?
And Linux and SELinux users and similar would be role references?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to suggest some direct guidelines that would help writers make a decision. I was thinking something on the lines of:
"Task performers" -> Use animate
"Role references"-> Use inanimate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've thought about this, but I think this is too simple a recommendation. We can refer to personal users even when they are not task performers. In fact, we should typically refer to task performers as "you" and write directly to them.
Also, we should primarily write around role references instead of using the inanimate pronouns.
So I think the current recommendation is more accurate:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... it is assigned to.
Hereit
is inanimate and I believe it is referring toA Linux user
. But IIUC,Linux user
is still animate here, in which case we might have to say ..they are assigned to.
instead. Feel free to correct me here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the Linux user here does not refer to a person who uses linux, but to the Linux user account, like
guest
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we may want to emphasize on that too since it is overlooked currently.
e.g.
image:images/no.png[no] A _Linux user_ has the restrictions of the _SELinux user who it is_ assigned to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I tried to emphasize only the parts of speech to which the pronouns point (and the pronouns themselves). I think emphasizing this user would make it less clear, because no pronoun refers to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought
it
refers toLinux user