Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Satellite "Product" #507

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Remove Satellite "Product" #507

merged 1 commit into from
Jul 25, 2024

Conversation

apinnick
Copy link
Contributor

@apinnick apinnick commented Jul 21, 2024 •
edited
Loading

Satellite no longer capitalizes "Product".

Issue: theforeman/foreman-documentation#3148

Additional information:

@apinnick
Remove Satellite "Product"
9f9c796 
Satellite no longer capitalizes "Product".
@apinnick apinnick mentioned this pull request Jul 21, 2024
Closed
dfitzmau
dfitzmau approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@dfitzmau dfitzmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked a local build of this branch and I can see that the product entry has been removed.

LGTM

bburt-rh
bburt-rh approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@bburt-rh bburt-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sbmetz
sbmetz approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@sbmetz sbmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbmetz sbmetz merged commit 34fb798 into redhat-documentation:main Jul 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbmetz sbmetz sbmetz approved these changes

@dfitzmau dfitzmau dfitzmau approved these changes

@bburt-rh bburt-rh bburt-rh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apinnick @sbmetz @dfitzmau @bburt-rh