Library: add ability to get a test list

[edcdavid]

Extracts the check listing component from the operatorCheck and containerCheck Run functions and exposes a "List" function. This code using the library to list the checks (including full metadata) that are executed by the Run function without actually running the checks.
A new Err field is added to the Result struct to report the detail of errors (generated by ExecuteChecks, see

openshift-preflight/internal/engine/engine.go

Line 234 in 31f7e81

c.results.Errors = appendUnlessOptional(c.results.Errors, certification.Result{Check: check, ElapsedTime: checkElapsedTime})

) via the library. The same field is also used construct a Results struct in case the test could not be ran at all.
see: redhat-best-practices-for-k8s/certsuite#1684

[openshift-ci]

Hi @edcdavid. Thanks for your PR.

I'm waiting for a redhat-openshift-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dcibot]

• SUCCESS https://www.distributed-ci.io/jobs/f8eb8e02-979f-4b19-a9f8-d3fc794ab1ea/jobStates
  from Library: add ability to get a test list #1100

[acornett21]

Hi @edcdavid preflight already has the function to list the checks via preflight list-checks, is this what you are looking for?

[edcdavid]

Hi @edcdavid preflight already has the function to list the checks via preflight list-checks, is this what you are looking for?

Hi @acornett21 thanks! I believe that would work. I missed it before . I will close the PR

[edcdavid]

This seems already supported by:
engine.OperatorPolicy(context.TODO())
engine.ContainerPolicy(context.TODO())

[edcdavid]

@acornett21, Can I use InitializeOperatorChecks directly to get the other metadata fields for the check? I also proposed in this PR to add an Err field in the Result structure.

[acornett21]

/ok-to-test

[dcibot]

• SUCCESS https://www.distributed-ci.io/jobs/5be7553b-82a0-4d60-90df-aba6cc42934b/jobStates
  from Library: add ability to get a test list #1100

[dcibot]

• SUCCESS https://www.distributed-ci.io/jobs/6a3b3669-b570-4733-9c9a-bf51a4563b92/jobStates
  from Library: add ability to get a test list #1100

[dcibot]

• SUCCESS https://www.distributed-ci.io/jobs/e7d4f849-faaf-4523-97a4-145c8d000aa9/jobStates
  from Library: add ability to get a test list #1100

[Apetree100122]

Please review

[Apetree100122]

Can we also resolve the spam block from github for me I never intentionally acted rude if I did I apologize I have not worked with a group on all my projects and if I offended sorry

[dcibot]

• SUCCESS https://www.distributed-ci.io/jobs/caa3ec56-cd4b-4cb0-97c9-a68d035ec6e9/jobStates
  from Library: add ability to get a test list #1100

[dcibot]

• SUCCESS https://www.distributed-ci.io/jobs/29e73544-b96c-4106-8cd5-963612487fdf/jobStates
  from Library: add ability to get a test list #1100

[komish]

/lgt

[bcrochet]

I bit about moving the field to be private. LMKWYT.

[dcibot]

from change #1100:

• SUCCESS https://www.distributed-ci.io/jobs/4da7fcac-c9ba-4a06-8ba4-d250d17a3473/jobStates

[dcibot]

from change redhat-best-practices-for-k8s/certsuite#1684:

• FAILURE https://www.distributed-ci.io/jobs/8add7736-662a-4557-8021-138557f5b147/jobStates

[bcrochet]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bcrochet, edcdavid, komish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bcrochet,komish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dcibot]

from change redhat-best-practices-for-k8s/certsuite#1684:

• FAILURE https://www.distributed-ci.io/jobs/569090bd-b877-4be5-a3c9-5af384449911/jobStates