Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone support #344. #345

Closed

Conversation

ioggstream
Copy link
Contributor

Added timezone parameter to openshift.yaml.

The default is Etc/UTC.

Feedback welcome!

@markllama
Copy link
Contributor

Heh. Personally, as someone who's run services at global ISPs, There Is Only One Timezone and It Is UTC.

That said, I'm not the only person with an opinion. We'll have to get some feedback from others. I'll take a look.

@ioggstream
Copy link
Contributor Author

Hi @markllama. Agreed.

It may happen that some iso images are PDT or other (maily us) timezones. Adding this param:

  • we ensure the tz is UTC by default
  • we enable customizations (I'm deliverying a self-service, per-tenant openshift)

Thx for your feedback + Peace,
R.

@tomassedovic
Copy link
Contributor

What worries me here that this change seems to have nothing to do with openshift as such and I worry that we'd end up with options for every conceivable server configuration.

I have 2 questions @ioggstream:

  1. does this have to be set before the openshift installation or can it happen afterwards
  2. would you be okay with a more general approach: e.g. specifying extra cloud-config options or maybe a custom pre-installation playbook you could pass in the Heat parameters?

@ioggstream
Copy link
Contributor Author

@tomassedovic Thanks for answering!

  1. a more general approach is fine: I agree about avoiding server-parameter proliferation
  2. using heat in some way (eg. all hosts inherit a CloudConfig from openshift.yaml) can be fine
  3. using ansible: this means we get logs with bad timestamps during cloud-init. This makes debugging hard when cross-checking bw openstack and openshift-on-openstack

Feel free to spam me at will here and on #openshift ;)

Thx++,
R.

@ioggstream
Copy link
Contributor Author

@tomassedovic @markllama I implemented your suggested approach in #356 .

We could move much of the boilerplate code there too ;)

Let me know + Peace,
R.

@ioggstream ioggstream closed this May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants