Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi run #124

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Multi run #124

wants to merge 8 commits into from

Conversation

dvalinrh
Copy link
Contributor

@dvalinrh dvalinrh commented Oct 21, 2024

Update zathras to allow for simultaneous execution of numerous zathras scenarios from the same run directory.

Issue #75
Relates to JIRA: RPOPC-261

@dvalinrh dvalinrh requested a review from a team October 21, 2024 15:01
Copy link
Member

@kdvalin kdvalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor questions

bin/burden Show resolved Hide resolved
bin/burden Outdated Show resolved Hide resolved
bin/burden Outdated Show resolved Hide resolved
bin/burden Outdated Show resolved Hide resolved
bin/burden Outdated Show resolved Hide resolved
bin/burden Outdated Show resolved Hide resolved
bin/burden Outdated Show resolved Hide resolved
bin/burden Outdated Show resolved Hide resolved
@kdvalin
Copy link
Member

kdvalin commented Jan 7, 2025

@dvalinrh This has a merge conflict, resolve it and I'll re-review.

Fix merge issues.  Only check burden in, not the other misc files that we have not changed.
@dvalinrh dvalinrh requested a review from kdvalin January 13, 2025 16:19
@dvalinrh
Copy link
Contributor Author

Add a lock comment for when we need it and do not need it.

Copy link

github-actions bot commented Feb 5, 2025

This relates to RPOPC-261

@dvalinrh dvalinrh requested a review from a team February 5, 2025 14:12
Copy link
Contributor

@frival frival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, but I left a question about the number passed to the lock functions.

gl_lock_exclusive()
{
if [[ $gl_debug_lock -eq 1 ]]; then
echo lock $1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the arg passed is purely for debug? It'd be good to note that, though I'm still wondering if this is going to cause an issue at some point down the road but maybe it's good enough for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants