-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi run #124
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor questions
@dvalinrh This has a merge conflict, resolve it and I'll re-review. |
Fix merge issues. Only check burden in, not the other misc files that we have not changed.
Add a lock comment for when we need it and do not need it. |
This relates to RPOPC-261 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, but I left a question about the number passed to the lock functions.
gl_lock_exclusive() | ||
{ | ||
if [[ $gl_debug_lock -eq 1 ]]; then | ||
echo lock $1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the arg passed is purely for debug? It'd be good to note that, though I'm still wondering if this is going to cause an issue at some point down the road but maybe it's good enough for now?
Update zathras to allow for simultaneous execution of numerous zathras scenarios from the same run directory.
Issue #75
Relates to JIRA: RPOPC-261