Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR Requirement Checking #145

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

kdvalin
Copy link
Member

@kdvalin kdvalin commented Jan 13, 2025

Description

This PR adds a github action workflow to check for properly structured PRs. This will check for a reference to a GitHub issue within the same repository, and a ticket within the relevant board on our Jira instance.

This will trigger when a PR is opened, and when the PR description has been edited.

Before/After Comparison

Before

A PR could be submitted and contain no references to any Jira ticket or GitHub issue

After

A PR needs a Jira reference along with a reference to a GitHub issue. Jira ticket numbers are not checked due to permission headaches.

There is no associated github issue or Jira ticket with this PR.

@kdvalin kdvalin requested a review from a team January 15, 2025 15:17
dvalinrh
dvalinrh previously approved these changes Jan 21, 2025
Copy link
Contributor

@dvalinrh dvalinrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dvalinrh dvalinrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdvalin kdvalin merged commit 03e68e7 into redhat-performance:main Jan 21, 2025
0 of 3 checks passed
@kdvalin kdvalin deleted the ci/pr-requirements branch January 21, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants