WIP: Add Image/Package Mode feature to os_vendor
#166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le simultaneous Zathras processes
|
This relates to RPOPC-326 |
dvalinrh
requested changes
Feb 12, 2025
| fi | ||
| done | ||
| if [[ $os_vendor_found -eq 0 ]]; then | ||
| cleanup_and_exit "Error: $1, is an unrecognized OS vendor. Possible values are: $gl_valid_os_vendors" 1 | ||
| fi | ||
|
|
||
| if [ -n "$os_args" ]; then |
| fi | ||
| ;; | ||
| *) | ||
| cleanup_and_exit "Error $mode is an unknown mode, valid options are: 'package' and 'image'" 1 |
There was a problem hiding this comment.
You need to remove the temp file on failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to simply specify
os_vendor: rhel:mode=imageto work with bootc images.Presently all this does is enable --no_packages automatically since you cannot install packages in bootc/image mode.
Before/After Comparison
Before
User would need to manually specify
--no_packagesand a writable--kit_upload_directoryto make Zathras work.After
The user needs to only specify
--os_mode=bootcor add it to theos_vendorin the scenario file, likeos_vendor: rhel:mode=image.Clerical Stuff
This closes #165
Relates to JIRA: RPOPC-326