-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8s: Simplify the update REC credential step #1147
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (after reading some K8s docs)
Looks good! Only suggestion is that we clarify the differences in the credentials used in Change the REC password for the current username
Change both the REC username and password
|
--save-config \ | ||
--dry-run=client \ | ||
--from-literal=username=<username> \ | ||
--from-literal=password=<password> \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using <new-password>
placeholder. Previously we had this emphasized via the now-removed 3b section.
--from-literal=username=<username> \ | ||
--from-literal=password=<password> \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, consider <new_username>
and <new_password>
.
-o yaml | \ | ||
kubectl apply -f | ||
kubectl apply -f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command is broken - it should end with kubectl apply -f -
(the -f -
indicates to read the input from stdin).
Same applies to the previous section with a similar command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this, Zvi. The last line of both kubectl commands should read:
kubectl apply -f -
@kaitlynmichael I am assuming you are testing the new steps, correct? |
Jira: DOC-4813