Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s: Simplify the update REC credential step #1147

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kaitlynmichael
Copy link
Contributor

Jira: DOC-4813

@kaitlynmichael kaitlynmichael requested a review from a team February 7, 2025 22:14
@kaitlynmichael kaitlynmichael self-assigned this Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (after reading some K8s docs)

@markotrapani
Copy link

markotrapani commented Feb 7, 2025

Looks good! Only suggestion is that we clarify the differences in the credentials used in kubectl between the two sections

Change the REC password for the current username

kubectl create secret generic <cluster_secret_name> \
  --save-config \
  --dry-run=client \
  --from-literal=username=<current_username> \
  --from-literal=password=<new_password> \
  -o yaml | \
kubectl apply -f - 

Change both the REC username and password

kubectl create secret generic <cluster_secret_name> \
  --save-config \
  --dry-run=client \
  --from-literal=username=<new_username> \
  --from-literal=password=<new_password> \
  -o yaml | \
kubectl apply -f - 

--save-config \
--dry-run=client \
--from-literal=username=<username> \
--from-literal=password=<password> \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using <new-password> placeholder. Previously we had this emphasized via the now-removed 3b section.

Comment on lines +114 to +115
--from-literal=username=<username> \
--from-literal=password=<password> \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, consider <new_username> and <new_password>.

-o yaml | \
kubectl apply -f
kubectl apply -f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command is broken - it should end with kubectl apply -f - (the -f - indicates to read the input from stdin).
Same applies to the previous section with a similar command.

Copy link

@markotrapani markotrapani Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, Zvi. The last line of both kubectl commands should read:
kubectl apply -f -

@yuvallevy2
Copy link

@kaitlynmichael I am assuming you are testing the new steps, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants