DEV+INT: update INFO command and Prometheus v2 metrics for search #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwdougherty
requested review from
meiravgri
and removed request for
maayanagranat
rrelledge
approved these changes
Feb 11, 2025
content/integrate/prometheus-with-redis-enterprise/prometheus-metrics-definitions.md
Outdated
Show resolved
Hide resolved
content/integrate/prometheus-with-redis-enterprise/prometheus-metrics-definitions.md
Outdated
Show resolved
Hide resolved
content/integrate/prometheus-with-redis-enterprise/prometheus-metrics-definitions.md
Outdated
Show resolved
Hide resolved
meiravgri
reviewed
Feb 12, 2025
There was a problem hiding this comment.
Looks good!
- Please add the version in which each of metric was introduced.
- In the shard section, all Prometheus metrics—including search metrics—are prefixed with
redis_server.For example,search_total_query_execution_time_mswould be recorded asredis_server_search_total_query_execution_time_ms
Co-authored-by: Rachel Elledge <[email protected]>
|
Thank you @rrelledge and @meiravgri ! All comments addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC-4611
INFO command page and Prometheus for RS v2 page updates.