-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-4816 added Jedis AMR connection page #1166
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Language LGTM.
Thanks @dwdougherty ! |
CC: @atakavci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andy-stark-redis, as i see focus is more on security artifacts in builder arguments that bridge this API to Azure Identity services. It looks good enough for a developer to start playing with API and experiment in their own environment. For the actual use cases however, i think we need to consider explaining parameters relevant to renewal intervals, retry behavior and related parameters; like expirationRefreshRatio , maxAttemptsToRetry, delayInMsToRetry...
We can take a look together in a short session if you prefer. Or may be i can try to write something down but not sure it would be efficient for both of us TBH.
The example below shows how to include the `TokenAuthConfig` details in a | ||
`JedisClientConfig` instance and use it with the `UnifiedJedis` connection. | ||
|
||
{{< note >}} Azure requires you to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not so sure if this is correct info. AFAIK it s just TLS is suggested and enabled by default with new managed instances.
The [`redis-authx-entraid`](https://github.com/redis/jvm-redis-authx-entraid) package | ||
lets you authenticate your app to | ||
[Azure Managed Redis (AMR)](https://azure.microsoft.com/en-us/products/managed-redis) | ||
using [Microsoft Entra ID](https://learn.microsoft.com/en-us/entra/identity/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe it also worth to mention this link; these resources more direct when your focus is on working with EntraID enabled AMR. https://learn.microsoft.com/en-us/azure/azure-cache-for-redis/cache-azure-active-directory-for-authentication
DOC-4816
I think I've figured this out OK from the source code and the README but I wasn't able to run the code, so please be alert for mistakes :-)
Note: I've assumed that SSL is required because that was stated in the redis-py-entraid README, so I've added some SSL details for the Jedis example too.