Skip to content

Commit

Permalink
fix: fix mypy linting in pre-commit
Browse files Browse the repository at this point in the history
pre-commit hook was previously ignoring missing modules; this allowed
some errors to get past CI
  • Loading branch information
ethanwu10 committed Jun 24, 2020
1 parent 14e1b8f commit 793def1
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ repos:
- id: mypy
name: mypy
entry: poetry run mypy
args: ["--ignore-missing-imports", "--scripts-are-modules"]
args: ["--scripts-are-modules"]
language: system
types: [python]
require_serial: true
2 changes: 1 addition & 1 deletion rcds/challenge/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
)
from warnings import warn

import jsonschema
import jsonschema # type: ignore

from rcds import errors

Expand Down
2 changes: 1 addition & 1 deletion rcds/project/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from pathlib import Path
from typing import Any, Dict, Iterable, Optional, Tuple, Union, cast

import jsonschema
import jsonschema # type: ignore

from rcds import errors

Expand Down

0 comments on commit 793def1

Please sign in to comment.