[gh46] Resize the YouTube video #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Walker-GM
approved these changes
Aug 19, 2024
|
Is there one particular aspect ratio that is by far the most common? If so we could set that as the default to lessen the potential layout shift when the resize happens. |
|
@Josh-Walker-GM Thanks for taking a look at this! 🙏 I'd guess the standard is 16:9 or 1920 x 1080. But, code tutorials are notorious for not following standard video conventions and basing it off the developers own screen resolution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue #46
Feature description
There was a bug where YouTube videos weren't being displayed correctly.
Solution description
Code looks to see if there are any embeds and then uses the YouTube API to determine and set the aspect ratio of the video.