refactor(defaultAdvertisingId): extract creating defaultAdvertisingId…

… into separate Util property
rees46 · Jan 10, 2025 · 66d6416 · 66d6416
1 parent 7d909e0
commit 66d6416
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/.../advertising/AdvertisingRepositoryImpl.kt → ...dvertising/Advertising.repository.impl.kt b/.../advertising/AdvertisingRepositoryImpl.kt → ...dvertising/Advertising.repository.impl.kt
@@ -2,8 +2,8 @@ package com.personalization.sdk.data.repositories.advertising
 
 import android.content.Context
 import com.google.android.gms.ads.identifier.AdvertisingIdClient
+import com.personalization.sdk.data.utils.AdvertisingUtils
 import com.personalization.sdk.domain.repositories.AdvertisingRepository
-import java.util.UUID
 import javax.inject.Inject
 
 class AdvertisingRepositoryImpl @Inject constructor(
@@ -13,11 +13,6 @@ class AdvertisingRepositoryImpl @Inject constructor(
         try {
             AdvertisingIdClient.getAdvertisingIdInfo(context).id
         } catch (e: Exception) {
-            generateDefaultAdvertisingId()
+            AdvertisingUtils.DEFAULT_ADVERTISING_ID
         }
-
-    private fun generateDefaultAdvertisingId(): String {
-        return UUID(0L, 0L).toString()
-    }
-
 }
diff --git a/...serSettings/UserSettingsRepositoryImpl.kt → ...rSettings/UserSettings.repository.impl.kt b/...serSettings/UserSettingsRepositoryImpl.kt → ...rSettings/UserSettings.repository.impl.kt
@@ -1,6 +1,7 @@
 package com.personalization.sdk.data.repositories.userSettings
 
 import com.personalization.sdk.data.repositories.preferences.PreferencesDataSource
+import com.personalization.sdk.data.utils.AdvertisingUtils
 import com.personalization.sdk.domain.repositories.UserSettingsRepository
 import javax.inject.Inject
 
@@ -9,7 +10,6 @@ private const val DEFAULT_SID = ""
 private const val DEFAULT_SID_LAST_ACT_TIME = 0L
 private const val DEFAULT_SHOP_ID = ""
 private const val DEFAULT_STREAM = "android"
-private const val DEFAULT_ADVERTISING_ID = "00000000-0000-0000-0000-000000000000"
 
 private const val DID_KEY = "did"
 private const val SID_KEY = "sid"
@@ -102,7 +102,7 @@ class UserSettingsRepositoryImpl @Inject constructor(
 
     override fun getAdvertisingId(): String = preferencesDataSource.getValue(
         field = ADVERTISING_ID_KEY,
-        defaultValue = DEFAULT_ADVERTISING_ID
+        defaultValue = AdvertisingUtils.DEFAULT_ADVERTISING_ID
     )
 
     override fun updateAdvertisingId(value: String) {

diff --git a/personalization-sdk/src/main/kotlin/com/personalization/sdk/data/utils/Advertising.utils.kt b/personalization-sdk/src/main/kotlin/com/personalization/sdk/data/utils/Advertising.utils.kt
@@ -0,0 +1,8 @@
+package com.personalization.sdk.data.utils
+
+import java.util.UUID
+
+object AdvertisingUtils {
+
+    val DEFAULT_ADVERTISING_ID = UUID(0L, 0L).toString()
+}