Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update the way secrets are injected for publishing #184

Merged
merged 1 commit into from
Sep 10, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/publish-release.yml
Original file line number Diff line number Diff line change
@@ -98,9 +98,11 @@ jobs:
- name: Publish to Maven
run: ./gradlew publish
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
CREEPERHOST_MAVEN_USERNAME: ${{ secrets.CREEPERHOST_MAVEN_USERNAME }}
CREEPERHOST_MAVEN_TOKEN: ${{ secrets.CREEPERHOST_MAVEN_TOKEN }}
# https://docs.gradle.org/current/samples/sample_publishing_credentials.html#header
ORG_GRADLE_PROJECT_GitHubPackagesUsername: ${{ env.GITHUB_ACTOR }}
ORG_GRADLE_PROJECT_GitHubPackagesPassword: ${{ secrets.GITHUB_TOKEN }}
ORG_GRADLE_PROJECT_CreeperHostUsername: ${{ secrets.CREEPERHOST_MAVEN_USERNAME }}
ORG_GRADLE_PROJECT_CreeperHostPassword: ${{ secrets.CREEPERHOST_MAVEN_TOKEN }}

publish-javadoc:
name: Publish Javadoc
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -7,6 +7,10 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

### Fixed

- Fixed publishing not working with the config cache.

## [0.19.0] - 2024-09-10

### Added
4 changes: 0 additions & 4 deletions refinedarchitect-plugin/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -38,10 +38,6 @@ publishing {
maven {
name = "GitHubPackages"
url = project.uri("https://maven.pkg.github.com/" + System.getenv("GITHUB_REPOSITORY"))
credentials {
username = System.getenv("GITHUB_ACTOR")
password = System.getenv("GITHUB_TOKEN")
}
}
}
}
8 changes: 0 additions & 8 deletions refinedarchitect-plugin/src/main/kotlin/BaseExtension.kt
Original file line number Diff line number Diff line change
@@ -103,18 +103,10 @@ open class BaseExtension(private val project: Project) {
maven {
name = "GitHubPackages"
url = project.uri("https://maven.pkg.github.com/" + System.getenv("GITHUB_REPOSITORY"))
credentials {
username = System.getenv("GITHUB_ACTOR")
password = System.getenv("GITHUB_TOKEN")
}
}
maven {
name = "CreeperHost"
url = project.uri("https://maven.creeperhost.net/release")
credentials {
username = System.getenv("CREEPERHOST_MAVEN_USERNAME")
password = System.getenv("CREEPERHOST_MAVEN_TOKEN")
}
}
}
publications {
4 changes: 0 additions & 4 deletions refinedarchitect-versioning/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -46,10 +46,6 @@ publishing {
maven {
name = "GitHubPackages"
url = project.uri("https://maven.pkg.github.com/" + System.getenv("GITHUB_REPOSITORY"))
credentials {
username = System.getenv("GITHUB_ACTOR")
password = System.getenv("GITHUB_TOKEN")
}
}
}
publications {