Autocrafter locking #785
Merged
Autocrafter locking #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add TaskListener so that pattern providers know when an iteration has been satisfied for the "lock until all outputs are received" locking mode.
When a merge happens, the network is just overridden, however, the parents stay the same. This would leak old parent instances and send double success toasts when a task is finished. When merge, we remove it too.
raoulvdberge
force-pushed
the
feat/GH-612/autocrafter-locking
branch
from
554d4b6 to
5c43ecc
Compare
Task removed can be called by task completed. We are now making this differentiation since 5c43ecc because we do not want toast messages when the network changes. Also hardens some tests.
raoulvdberge
force-pushed
the
feat/GH-612/autocrafter-locking
branch
from
a54bb59 to
fcfa74d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #612