-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.0.0-milestone.4.12 #786
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge main into develop branch
…tect chore: upgrade refined architect
New Crowdin updates
Controller gametest
Relay gametest
Item/Fluid storage blocks gametest
feat: autocrafting calculation
We always have to add the resulting output resources to the internal storage, even if there are missing resources. If we would not do this, then, in the case of missing resources, it would re-calculate the same ingredient from scratch everytime and use way too much resources. However, if we always add resulting resources, even if there are missing items, we must still use up the yields from the recursive calculation. Otherwise, if we would not use up the yields from the recursive calculation, the crafting calculation would incorrectly use up resources from the internal storage for other ingredients. What is the difference between not adding the yields in case of missing resources and using up the recursive yields when there were missing resources? The difference lies in the fact that, when we do not add *any* yields, the crafting calculation would start from scratch everytime for each ingredient. Only using up what we needed in the first place from the recursive yield ensures that any _leftover_ yields can still be used up by other ingredients that happen to need the same resource. So, the difference lies in not having any yields at all versus still allowing access to the leftovers.
Tooltips need to be at 0.7 The default scale should be 0.5
…itor Autocrafting monitor support for tasks
…o account Feature parity with RS1
Autocrafting notifications
Persist autocrafting tasks
This way, tasks will be able to round robin for sinks for processing balancing.
Pattern instances are unique because they have an ID. For processing pattern balancing we need to be able to query based on the layout, rather than the unique instance.
This caused loaded tasks not being able to be cancelled when reloading a world.
…cing Processing pattern balancing
Add TaskListener so that pattern providers know when an iteration has been satisfied for the "lock until all outputs are received" locking mode.
When a merge happens, the network is just overridden, however, the parents stay the same. This would leak old parent instances and send double success toasts when a task is finished. When merge, we remove it too.
Task removed can be called by task completed. We are now making this differentiation since 5c43ecc because we do not want toast messages when the network changes. Also hardens some tests.
Autocrafter locking
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @raoulvdberge!
This PR was created in response to a manual trigger of the release workflow here: https://github.com/refinedmods/refinedstorage2/actions/runs/12999245588.
Merging this PR will publish the release.