Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.0.0-milestone.4.12 #786

Merged
merged 114 commits into from
Jan 27, 2025
Merged

Release v2.0.0-milestone.4.12 #786

merged 114 commits into from
Jan 27, 2025

Conversation

raoulvdberge
Copy link
Contributor

Hi @raoulvdberge!
This PR was created in response to a manual trigger of the release workflow here: https://github.com/refinedmods/refinedstorage2/actions/runs/12999245588.
Merging this PR will publish the release.

raoulvdberge and others added 30 commits December 8, 2024 12:38
Merge main into develop branch
We always have to add the resulting output
resources to the internal storage, even if there
are missing resources.
If we would not do this, then, in the case of
missing resources, it would re-calculate
the same ingredient from scratch everytime and
use way too much resources.

However, if we always add resulting resources,
even if there are missing items, we must still
use up the yields from the recursive calculation.
Otherwise, if we would not use up the yields
from the recursive calculation, the crafting
calculation would incorrectly use up resources
from the internal storage for other ingredients.

What is the difference between not adding the yields
in case of missing resources and using up the recursive
yields when there were missing resources?
The difference lies in the fact that, when we do not
add *any* yields, the crafting calculation would start
from scratch everytime for each ingredient.
Only using up what we needed in the first place from the
recursive yield ensures that any _leftover_ yields
can still be used up by other ingredients that happen
to need the same resource.
So, the difference lies in not having any yields at
all versus still allowing access to the leftovers.
raoulvdberge and others added 26 commits January 26, 2025 16:10
Tooltips need to be at 0.7
The default scale should be 0.5
…itor

Autocrafting monitor support for tasks
This way, tasks will be able to round
robin for sinks for processing
balancing.
Pattern instances are unique because
they have an ID.
For processing pattern balancing
we need to be able to query based
on the layout, rather than the
unique instance.
This caused loaded tasks not being able
to be cancelled when reloading
a world.
Add TaskListener so that pattern providers
know when an iteration has been
satisfied for the "lock until all outputs are received"
locking mode.
When a merge happens, the network is just
overridden, however,
the parents stay the same.
This would leak old parent instances
and send double success
toasts when a task is finished.
When merge, we remove it too.
Task removed can be called by task completed.
We are now making this differentiation since 5c43ecc
because we do not want toast messages
when the network changes.

Also hardens some tests.
@raoulvdberge raoulvdberge merged commit 690b942 into main Jan 27, 2025
7 checks passed
@raoulvdberge raoulvdberge deleted the release/2.0.0-milestone.4.12 branch January 27, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants