Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ComputedVar overloads for BASE_TYPE, SQLA_TYPE, and DATACLASS_TYPE #4777

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

masenf
Copy link
Collaborator

@masenf masenf commented Feb 8, 2025

Allow typing to find __getattr__ for rx.var that returns an object-like model.

Allow typing to find __getattr__ for rx.var that returns an object-like model.
Copy link

codspeed-hq bot commented Feb 8, 2025

CodSpeed Performance Report

Merging #4777 will not alter performance

Comparing masenf/computed-var-overloads-for-objectvar (50d0aaa) with main (70920a6)

Summary

✅ 8 untouched benchmarks

@masenf masenf merged commit 8b2c729 into main Feb 8, 2025
39 checks passed
@masenf masenf deleted the masenf/computed-var-overloads-for-objectvar branch February 8, 2025 01:38
masenf added a commit that referenced this pull request Feb 8, 2025
#4777)

Allow typing to find __getattr__ for rx.var that returns an object-like model.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants